Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new instances of HLTCaloObjInRegionsProducer for HLT filtering: 91X #18583

Merged
merged 1 commit into from May 5, 2017

Conversation

Sam-Harper
Copy link
Contributor

This is the 91X flavour of #18544.

It is necessary to be able to prefilter HCAL PhaseI digis so that method2 can be run on rec-hits of interest to E/gamma in the HLT.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

A new Pull Request was created by @Sam-Harper for CMSSW_9_1_X.

It involves the following packages:

DataFormats/EcalDigi
RecoEgamma/EgammaHLTProducers

@cmsbuild, @civanch, @silviodonato, @mdhildreth, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @rafaellopesdesa, @lgray, @calderona, @HuguesBrun, @argiro this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19592/console Started: 2017/05/05 11:33

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18583/19592/summary.html

Comparison Summary:

  • You potentially added 48 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 3380 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831050
  • DQMHistoTests: Total failures: 48233
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1782637
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6 davidlange6 merged commit 3f22d41 into cms-sw:CMSSW_9_1_X May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants