lower pt cut on dedxhitinfo to 10 GeV and add dedx harmonic2 for pixel hits

[slava77]

Lowering of pt from 15 GeV to 10 GeV increases signal yields by 10% for short (pixel-only) heavy high pt tracks.

Addition of the pixel-only harmonic2 enables calibration from AOD (it has to be done on low pt tracks; hence full addition).

the cost to AOD is about 1% (1 kB/event from the dedxHitInfo lower threshold and 3kB/evt from the pixel-only harmonic2) based on checks in ttbar and Run2016H JetHT data. This estimate was made in 80X.

The addition of dedx estimator for pixel to AOD is directly related to https://indico.cern.ch/event/638437/contributions/2595782/attachments/1460494/2255768/stoppedtracks_xpog_170516.pdf (see minutes for it in https://indico.cern.ch/event/638437/contributions/2595782/note/)

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

RecoTracker/DeDx

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[gpetruc]

Don't you also need to add a keep *_dedxPixelHarmonic2_*_* in https://github.com/cms-sw/cmssw/blob/master/RecoTracker/Configuration/python/RecoTracker_EventContent_cff.py#L63 ?

[cmsbuild]

Pull request #18773 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

[slava77]

@cmsbuild please test

@gpetruc thanks for spotting the missing event content change, I had the change in local but not committed/pushed .. surprisingly I repeated the same in 80X as well

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19886/console Started: 2017/05/16 21:24

[cmsbuild]

+1
Tested at: f190f90
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18773/19886/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18773/19886/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 1679 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1833858
• DQMHistoTests: Total failures: 39165
• DQMHistoTests: Total nulls: 106
• DQMHistoTests: Total successes: 1794407
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[slava77]

+1

for #18773 f190f90

• jenkins tests pass and comparisons show differences only in DQM plots of /dedxHitInfo, corresponding to more tracks added to the plots as a result of lowering the threshold on selected tracks data to be saved
• local tests were done as a pre-submission step and impact is provided in the PR description

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1