Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid linkDef files for root6 #1881

Merged
merged 1 commit into from Dec 18, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Dec 18, 2013

Although the format of LinkDef.h files is the same in ROOT5 and ROOT6, the effects are not necessarily the same.
Because of this, some needed dictionaries were not loaded. and many framework unit tests failed against ROOT6.
LinkDef.h files were used in the framework for historical reasons only. The easiest way to fix the test errors is to use classes_def.xml and classes.h consistently throughout the framework for generating ROOT6 dictionaries.
Some minor refactoring of code in IOPool/TFileAdaptor was needed to do this.
While we could in principle do the same for ROOT 5, this is non-trivial in ROOT5 because two of the classes in question inherit from TObject. Because of the complexities of CINT, Cintex, and Reflex, additional work would be needed for ROOT5.
This pull request fixes many framework unit test errors against ROOT6.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_0_ROOT6_X.

Avoid linkDef files for root6

It involves the following packages:

FWCore/FWLite
IOPool/TFileAdaptor

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor

+1
Just to correct a statement in Bill's pull request. We can't use this in ROOT5 since the LinkDef.h were used explicitly to avoid having to use Cintex. As Bill pointed out in an offline conversation, ROOT6 doesn't have Cintex so that complication goes away.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

ktf added a commit that referenced this pull request Dec 18, 2013
ROOT6 -- Avoid linkDef files for root6
@ktf ktf merged commit 625442c into cms-sw:CMSSW_7_0_ROOT6_X Dec 18, 2013
@wmtan wmtan deleted the AvoidLinkDefForROOT6 branch December 18, 2013 22:33
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Update py2-dxr to use pysqlite 2.8 to load extension in sqlite 3.8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants