Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily disable setNoiseFlagsQIE11 for AlCa #18853

Merged
merged 1 commit into from May 23, 2017

Conversation

kpedro88
Copy link
Contributor

Followup to #18821, disabling setNoiseFlagsQIE11 for AlCaRECO sequences.

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

Calibration/HcalAlCaRecoProducers

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19991/console Started: 2017/05/19 15:37

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18853/19991/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 95 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833901
  • DQMHistoTests: Total failures: 32717
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1801004
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@ghellwig
Copy link

@kpedro88 is this PR intended to be merged or not?
I see that #18855 is a backport to CMSSW_9_2_0_patchX. But since this fix anyway just temporary, I am wondering if it makes sense to merge it in master or not...

@kpedro88
Copy link
Contributor Author

@ghellwig I think it should be merged in 92X since we're not sure when the needed parameters will become available

@ghellwig
Copy link

+1

@ghellwig
Copy link

thanks @kpedro88

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0fca914 into cms-sw:master May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants