Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnlineDQM: Add Chi2 2D Quality Test #18965

Merged
merged 1 commit into from Jun 6, 2017

Conversation

stahlleiton
Copy link
Contributor

Description:
Add a new Chi2 Quality Test to compare a 2D test histogram versus a 2D reference histogram for Online DQM. The Chi2 test is based on the test already implemented in the ROOT framework which is described here https://root.cern.ch/doc/master/classTH1.html#aa2cecbf3c6a20a1ec3d39b5ec139b6f2 and can be applied to 1D/2D/3D histograms.

Purpose:
The new Chi2 2D Quality Test will be used to compare 2D Online DQM histograms in order to build DQM automatic alarms for L1T.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @stahlleiton (Andre Stahl) for master.

It involves the following packages:

DQMServices/ClientConfig
DQMServices/Core

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@stahlleiton
Copy link
Contributor Author

Hi

@stahlleiton stahlleiton reopened this May 30, 2017
@stahlleiton
Copy link
Contributor Author

Sorry, I closed this PR by mistake. So I reopened it.
@dmitrijus, could you start the test? thanks.

@dmitrijus
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 31, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20248/console Started: 2017/05/31 16:49

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18965/20248/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-18965/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D10_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D10+RecoFullGlobal_2023D10+HARVESTFullGlobal_2023D10
  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-18965/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D18_GenSimHLBeamSpotFull14+DigiFull_2023D18+RecoFullGlobal_2023D18+HARVESTFullGlobal_2023D18
  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-18965/27434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFull_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1693 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1786072
  • DQMHistoTests: Total failures: 39325
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1746574
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3ad0dd3 into cms-sw:master Jun 6, 2017
@stahlleiton stahlleiton deleted the OnlineDQM_2DChi2QT_92X branch February 20, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants