Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on DQMOffline/Trigger for Muons #18968

Merged
merged 26 commits into from Jul 4, 2017
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion DQMOffline/Trigger/interface/HLTMuonMatchAndPlot.h
Expand Up @@ -44,6 +44,7 @@
#include "TNtuple.h"
#include "TString.h"
#include "TPRegexp.h"
#include "TLorentzVector.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @sscruz - this include should not be needed.



//////////////////////////////////////////////////////////////////////////////
Expand All @@ -70,7 +71,8 @@ class HLTMuonMatchAndPlot
void beginRun(DQMStore::IBooker &, const edm::Run &, const edm::EventSetup &);
void analyze(edm::Handle<reco::MuonCollection> &, edm::Handle<reco::BeamSpot> &,
edm::Handle<reco::VertexCollection> &, edm::Handle<trigger::TriggerEvent> &,
edm::Handle<edm::TriggerResults> &);
edm::Handle<edm::TriggerResults> &,
const edm::TriggerNames&);
void endRun(const edm::Run &, const edm::EventSetup &);

// Helper Methods
Expand Down
105 changes: 83 additions & 22 deletions DQMOffline/Trigger/python/HLTMuonOfflineAnalyzer_cff.py
Expand Up @@ -46,37 +46,98 @@
)


globalAnalyzer = hltMuonOfflineAnalyzer.clone()
globalAnalyzer.destination = "HLT/Muon/DistributionsGlobal"
globalAnalyzer.targetParams = globalMuonParams
#globalAnalyzer.probeParams = cms.PSet()

trackerAnalyzer = hltMuonOfflineAnalyzer.clone()
trackerAnalyzer.destination = "HLT/Muon/DistributionsTracker"
trackerAnalyzer.targetParams = trackerMuonParams
#trackerAnalyzer.probeParams = cms.PSet()

tightAnalyzer = hltMuonOfflineAnalyzer.clone()
tightAnalyzer.destination = "HLT/Muon/DistributionsTight"
tightAnalyzer.targetParams = tightMuonParams
globalAnalyzerTnP = hltMuonOfflineAnalyzer.clone()
globalAnalyzerTnP.destination = "HLT/Muon/DistributionsGlobal"
globalAnalyzerTnP.targetParams = globalMuonParams
#globalAnalyzerTnP.probeParams = cms.PSet()

trackerAnalyzerTnP = hltMuonOfflineAnalyzer.clone()
trackerAnalyzerTnP.destination = "HLT/Muon/DistributionsTracker"
trackerAnalyzerTnP.targetParams = trackerMuonParams
#trackerAnalyzerTnP.probeParams = cms.PSet()

tightAnalyzerTnP = hltMuonOfflineAnalyzer.clone()
tightAnalyzerTnP.destination = "HLT/Muon/DistributionsTight"
tightAnalyzerTnP.targetParams = tightMuonParams
#tightAnalyzerTnP.probeParams = cms.PSet()

looseAnalyzerTnP = hltMuonOfflineAnalyzer.clone()
looseAnalyzerTnP.destination = "HLT/Muon/DistributionsLoose"
looseAnalyzerTnP.targetParams = looseMuonParams
#tightAnalyzer.probeParams = cms.PSet()

looseAnalyzer = hltMuonOfflineAnalyzer.clone()
looseAnalyzer.destination = "HLT/Muon/DistributionsLoose"
looseAnalyzer.targetParams = looseMuonParams

globalAnalyzerRef = hltMuonOfflineAnalyzer.clone()
globalAnalyzerRef.destination = "HLT/Muon/DistributionsGlobal"
globalAnalyzerRef.targetParams = globalMuonParams
globalAnalyzerRef.hltPathsToCheck = cms.vstring(
"HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_v",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v",
"HLT_TkMu17_TrkIsoVVL_TkMu8_TrkIsoVVL_v",
"HLT_TkMu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v")
globalAnalyzerRef.requiredTriggers = cms.untracked.vstring(
"HLT_Mu17_TrkIsoVVL_v")

#globalAnalyzerRef.probeParams = cms.PSet()

trackerAnalyzerRef = hltMuonOfflineAnalyzer.clone()
trackerAnalyzerRef.destination = "HLT/Muon/DistributionsTracker"
trackerAnalyzerRef.targetParams = trackerMuonParams
trackerAnalyzerRef.hltPathsToCheck = cms.vstring(
"HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_v",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v",
"HLT_TkMu17_TrkIsoVVL_TkMu8_TrkIsoVVL_v",
"HLT_TkMu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v")
trackerAnalyzerRef.requiredTriggers = cms.untracked.vstring(
"HLT_Mu17_TrkIsoVVL_v")
#trackerAnalyzerRef.probeParams = cms.PSet()

tightAnalyzerRef = hltMuonOfflineAnalyzer.clone()
tightAnalyzerRef.destination = "HLT/Muon/DistributionsTight"
tightAnalyzerRef.targetParams = tightMuonParams
tightAnalyzerRef.hltPathsToCheck = cms.vstring(
"HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_v",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v",
"HLT_TkMu17_TrkIsoVVL_TkMu8_TrkIsoVVL_v",
"HLT_TkMu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v")
tightAnalyzerRef.requiredTriggers = cms.untracked.vstring(
"HLT_Mu17_TrkIsoVVL_v")
#tightAnalyzerRef.probeParams = cms.PSet()

looseAnalyzerRef = hltMuonOfflineAnalyzer.clone()
looseAnalyzerRef.destination = "HLT/Muon/DistributionsLoose"
looseAnalyzerRef.targetParams = looseMuonParams
looseAnalyzerRef.hltPathsToCheck = cms.vstring(
"HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_v",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v",
"HLT_TkMu17_TrkIsoVVL_TkMu8_TrkIsoVVL_v",
"HLT_TkMu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v")
looseAnalyzerRef.requiredTriggers = cms.untracked.vstring(
"HLT_Mu17_TrkIsoVVL_v")
#tightAnalyzer.probeParams = cms.PSet()




hltMuonOfflineAnalyzers = cms.Sequence(
globalAnalyzer *
trackerAnalyzer *
tightAnalyzer *
looseAnalyzer
globalAnalyzerTnP *
trackerAnalyzerTnP *
tightAnalyzerTnP *
looseAnalyzerTnP *
globalAnalyzerRef *
trackerAnalyzerRef *
tightAnalyzerRef *
looseAnalyzerRef
)

from Configuration.Eras.Modifier_pA_2016_cff import pA_2016
for muAna in [globalAnalyzer.targetParams, trackerAnalyzer.targetParams, tightAnalyzer.targetParams, looseAnalyzer.targetParams]:
for muAna in [globalAnalyzerTnP.targetParams, trackerAnalyzerTnP.targetParams,
tightAnalyzerTnP.targetParams, looseAnalyzerTnP.targetParams,
globalAnalyzerRef.targetParams, trackerAnalyzerRef.targetParams,
tightAnalyzerRef.targetParams, looseAnalyzerRef.targetParams,]:
pA_2016.toModify(muAna, ptCut_Jpsi = cms.untracked.double( 5.0))
for muAna in [globalAnalyzer.binParams, trackerAnalyzer.binParams, tightAnalyzer.binParams, looseAnalyzer.binParams]:
for muAna in [globalAnalyzerTnP.binParams, trackerAnalyzerTnP.binParams,
tightAnalyzerTnP.binParams, looseAnalyzerTnP.binParams,
globalAnalyzerRef.binParams, trackerAnalyzerRef.binParams,
tightAnalyzerRef.binParams, looseAnalyzerRef.binParams]:
pA_2016.toModify(muAna, ptCoarse = cms.untracked.vdouble(0.,1.,2.,3.,4.,5.,7.,9.,12.,15.,20.,30.,40.))
14 changes: 9 additions & 5 deletions DQMOffline/Trigger/python/HLTMuonOfflineAnalyzer_cfi.py
Expand Up @@ -10,14 +10,13 @@

## HLT paths passing any one of these regular expressions will be included
hltPathsToCheck = cms.vstring(
"HLT_Mu17_TrkIsoVVL_v",
"HLT_Mu45_eta2p1_v1",
"HLT_Mu50_v",
"HLT_IsoMu24_v",
"HLT_IsoTkMu24_v",
# "HLT_Mu17_Mu8_DZ_v",
# "HLT_Mu17_TkMu8_DZ_v",
"HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_v",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v",
"HLT_IsoMu20_eta2p1_v",
"HLT_IsoTkMu20_eta2p1_v",
"HLT_IsoMu24_eta2p1_v",
Expand Down Expand Up @@ -79,15 +78,19 @@
## Both 1D and 2D plots use the binnings defined here
binParams = cms.untracked.PSet(
## parameters for fixed-width plots
NVertex = cms.untracked.vdouble( 20, 1, 50),
NVertex = cms.untracked.vdouble( 20, 1, 60),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest you to slightly increase it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To what? 65?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtosi how about ( 20, 1, 100)?

NVertexFine= cms.untracked.vdouble( 40, 1, 60),
eta = cms.untracked.vdouble( 20, -2.40, 2.40),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't you make use of a variable bin width ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenjaminRS Does 0,5 and then from 10 to 55,with a step of 3 sound reasonable?

phi = cms.untracked.vdouble( 20, -3.14, 3.14),
z0 = cms.untracked.vdouble( 10, -15.00, 15.00),
phiHEP17 = cms.untracked.vdouble( -3.14,-2.4,-1.8,-1.0,-0.4,0.0,0.4,1.0,1.8,2.4,3.14),
z0 = cms.untracked.vdouble( 10, -0.15, 0.15),
z0Fine = cms.untracked.vdouble( 20, -0.15, 0.15),
d0 = cms.untracked.vdouble( 10, -0.50, 0.50),
zMass = cms.untracked.vdouble( 50, 65.00, 115.00),
jpsiMass = cms.untracked.vdouble( 60, 0.00, 6.00),
charge = cms.untracked.vdouble( 2, -2.00, 2.00),
deltaR = cms.untracked.vdouble( 20, 0.00, 0.05),
deltaR2 = cms.untracked.vdouble( 20, 0.0, 4.5 ),
phiCoarse = cms.untracked.vdouble( 10, -3.14, 3.14),
resolutionRel = cms.untracked.vdouble( 40, -0.30, 0.30),
resolutionEta = cms.untracked.vdouble( 20, -0.01, 0.01),
Expand All @@ -96,6 +99,7 @@
etaCoarse = cms.untracked.vdouble(-2.4, -2.1, -1.6, -1.2, -0.8, 0.0,
0.8, 1.2, 1.6, 2.1, 2.4),
ptCoarse = cms.untracked.vdouble(10.0, 20.0, 40.0, 60.0, 80.0, 100.0, 200.0),
ptFine = cms.untracked.vdouble(10.0,15.0, 20.0,30.0, 40.0,50.0, 60.0,70.0, 80.0,90.0, 100.0,150., 200.0),
pt = cms.untracked.vdouble( 0.0, 2.0, 4.0,
6.0, 8.0, 10.0,
20.0, 30.0, 40.0,
Expand All @@ -116,7 +120,7 @@
),

## Only events passing all these triggers will be considered
requiredTriggers = cms.untracked.vstring(),
requiredTriggers = cms.untracked.vstring(),

## This collection is used to fill most distributions
targetParams = cms.PSet(
Expand Down
109 changes: 103 additions & 6 deletions DQMOffline/Trigger/python/MuonPostProcessor_cff.py
Expand Up @@ -9,7 +9,21 @@
resolution = cms.vstring(),
efficiency = cms.vstring(
"efficiencyPhiVsEta 'Efficiency to Match Reco Muons to Trigger Objects; #eta^{reco}; #phi^{reco}' efficiencyPhiVsEta_numer efficiencyPhiVsEta_denom",
),
"TPefficiencyEtaZ 'Tag & Probe efficiency; #eta; N(tt) / N(tp)' massVsEtaZ_numer massVsEtaZ_denom",
"TPefficiencyPtZ 'Tag & Probe efficiency; p_{T}; N(tt) / N(tp)' massVsPtZ_numer massVsPtZ_denom",
"TPefficiencyDZZ 'Tag & Probe efficiency; DZ; N(tt) / N(tp)' massVsDZZ_numer massVsDZZ_denom",
"Refefficiency_Pt 'Reference efficiency; Pt; Pt' Refefficiency_Pt_numer Refefficiency_Pt_denom",
"Refefficiency_Eta 'Reference efficiency; Eta; Eta' Refefficiency_Eta_numer Refefficiency_Eta_denom",
"Refefficiency_Eta_Mu1 'Reference efficiency; Eta; N(pass) / N' Refefficiency_Eta_Mu1_numer Refefficiency_Eta_Mu1_denom",
"Refefficiency_Eta_Mu2 'Reference efficiency; Eta; N(pass) / N' Refefficiency_Eta_Mu2_numer Refefficiency_Eta_Mu2_denom",
"Refefficiency_Vertex 'Reference efficiency; NVertex; N(pass) / N' Refefficiency_Vertex_numer Refefficiency_Vertex_denom",
"Refefficiency_TurnOn_Mu1 'Reference efficiency; Pt; N(pass) / N' Refefficiency_TurnOn_Mu1_numer Refefficiency_TurnOn_Mu1_denom",
"Refefficiency_TurnOn_Mu2 'Reference efficiency; Pt; N(pass) / N' Refefficiency_TurnOn_Mu2_numer Refefficiency_TurnOn_Mu2_denom",
"Refefficiency_DZ_Mu 'Reference efficiency; d_{z}; N(pass) / N' Refefficiency_DZ_Mu_numer Refefficiency_DZ_Mu_denom",
"Refefficiency_DZ_Vertex 'Reference efficiency; d_{z}; N(pass) / N' Refefficiency_DZ_Vertex_numer Refefficiency_DZ_Vertex_denom",

),


efficiencyProfile = cms.untracked.vstring(
"efficiencyVertex 'Efficiency to Match Reco Muons to Trigger Objects; NVertex^{reco}; N(#mu matched to trigger object) / N(#mu)' efficiencyVertex_numer efficiencyVertex_denom",
Expand All @@ -23,18 +37,101 @@
"fakerateEta 'Trigger Fake Rate; #eta^{trigger}; N(unmatched trigger objects) / N(trigger objects)' fakerateEta_numer fakerateEta_denom",
"fakeratePhi 'Trigger Fake Rate; #phi^{trigger}; N(unmatched trigger objects) / N(trigger objects)' fakeratePhi_numer fakeratePhi_denom",
"fakerateTurnOn 'Trigger Fake Rate; p_{T}^{trigger}; N(unmatched trigger objects) / N(trigger objects)' fakerateTurnOn_numer fakerateTurnOn_denom",

"TPefficiencyEtaJPsi 'Tag & Probe efficiency; #eta; N(tt) / N(tp)' massVsEtaJpsi_numer massVsEtaJpsi_denom",
"TPefficiencyPtJPsi 'Tag & Probe efficiency; p_{T}; N(tt) / N(tp)' massVsPtJpsi_numer massVsPtJpsi_denom",
"TPefficiencyVertexJPsi 'Tag & Probe efficiency; NVertex; N(tt) / N(tp)' massVsVertexJpsi_numer massVsVertexJpsi_denom",
"TPefficiencyEtaZ 'Tag & Probe efficiency; #eta; N(tt) / N(tp)' massVsEtaZ_numer massVsEtaZ_denom",
"TPefficiencyPtZ 'Tag & Probe efficiency; p_{T}; N(tt) / N(tp)' massVsPtZ_numer massVsPtZ_denom",
"TPefficiencyVertexZ 'Tag & Probe efficiency; NVertex; N(tt) / N(tp)' massVsVertexZ_numer massVsVertexZ_denom"
"TPefficiencyDeltaR 'Tag & Probe efficiency; #Delta R; N(tt) / N(tp)' efficiencyDeltaR_numer efficiencyDeltaR_denom",
"TPefficiencyVertexZ 'Tag & Probe efficiency; NVertex; N(tt) / N(tp)' massVsVertexZ_numer massVsVertexZ_denom",

),

)

hltMuonEfficienciesMR = cms.EDAnalyzer("DQMGenericClient",

subDirs = cms.untracked.vstring("HLT/Muon/MR/Distributions.*"),
verbose = cms.untracked.uint32(0), # Set to 2 for all messages
outputFileName = cms.untracked.string(''),
commands = cms.vstring(),
resolution = cms.vstring(),
efficiency = cms.vstring(
"MR_efficiencyPhiVsEta 'Efficiency to Match Reco Muons to Trigger Objects; #eta^{reco}; #phi^{reco}' MR_efficiencyPhiVsEta_numer MR_efficiencyPhiVsEta_denom",
"MR_TPefficiencyPtZ 'Tag & Probe efficiency; p_{T}; N(tt) / N(tp)' MR_massVsPtZ_numer MR_massVsPtZ_denom",
"MR_TPefficiencyDZZ 'Tag & Probe efficiency; DZ; N(tt) / N(tp)' MR_massVsDZZ_numer MR_massVsDZZ_denom",
"MR_Refefficiency_Pt 'Reference efficiency; Pt; Pt' MR_Refefficiency_Pt_numer MR_Refefficiency_Pt_denom",
"MR_Refefficiency_TurnOn_Mu1 'Reference efficiency; Pt; N(pass) / N' MR_Refefficiency_TurnOn_Mu1_numer MR_Refefficiency_TurnOn_Mu1_denom",
"MR_Refefficiency_TurnOn_Mu2 'Reference efficiency; Pt; N(pass) / N' MR_Refefficiency_TurnOn_Mu2_numer MR_Refefficiency_TurnOn_Mu2_denom",
"MR_Refefficiency_Vertex 'Reference efficiency; NVertex; N(pass) / N' MR_Refefficiency_Vertex_numer MR_Refefficiency_Vertex_denom",
"MR_Refefficiency_DZ_Mu 'Reference efficiency; d_{z}; N(pass) / N' MR_Refefficiency_DZ_Mu_numer MR_Refefficiency_DZ_Mu_denom"


),


efficiencyProfile = cms.untracked.vstring(
"MR_TPefficiencyPtJPsi 'Tag & Probe efficiency; p_{T}; N(tt) / N(tp)' MR_massVsPtJpsi_numer MR_massVsPtJpsi_denom",
"MR_TPefficiencyVertexJPsi 'Tag & Probe efficiency; NVertex; N(tt) / N(tp)' MR_massVsVertexJpsi_numer MR_massVsVertexJpsi_denom",
"MR_TPefficiencyVertexZ 'Tag & Probe efficiency; NVertex; N(tt) / N(tp)' MR_massVsVertexZ_numer MR_massVsVertexZ_denom"

),

)

hltMuonRefEfficiencies = cms.EDAnalyzer("HLTMuonRefMethod",
subDirs = cms.untracked.vstring("HLT/Muon/Distributions.*"),
outputFileName = cms.untracked.string(''),
hltTriggers = cms.untracked.vstring("HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ"),
refTriggers = cms.untracked.string("HLT_Mu17_TrkIsoVVL"),
efficiency = cms.untracked.vstring( "Refefficiency_Eta_Mu1",
"Refefficiency_Eta_Mu2",
"Refefficiency_TurnOn_Mu1",
"Refefficiency_TurnOn_Mu2",
"Refefficiency_DZ_Mu",
"Refefficiency_Pt",
"Refefficiency_Eta",
"Refefficiency_DZ_Mu",
),
refEff = cms.untracked.vstring( 'TPefficiencyEtaZ',
'TPefficiencyEtaZ',
'TPefficiencyPtZ',
'TPefficiencyPtZ',
'TPefficiencyDZZ',
'TPefficiencyPtZ',
"TPefficiencyEtaZ",
'TPefficiencyDZZ',
),

)

hltMuonRefEfficienciesMR = cms.EDAnalyzer("HLTMuonRefMethod",
subDirs = cms.untracked.vstring("HLT/Muon/MR/Distributions.*"),
outputFileName = cms.untracked.string(''),
hltTriggers = cms.untracked.vstring("HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ"),
refTriggers = cms.untracked.string("HLT_Mu17_TrkIsoVVL"),
efficiency = cms.untracked.vstring( "MR_Refefficiency_TurnOn_Mu1",
"MR_Refefficiency_TurnOn_Mu2",
"MR_Refefficiency_DZ_Mu",
"MR_Refefficiency_Pt"
"MR_Refefficiency_DZ_Mu",
),
refEff = cms.untracked.vstring( 'MR_TPefficiencyPtZ',
'MR_TPefficiencyPtZ',
'MR_TPefficiencyDZZ',
'MR_TPefficiencyPtZ',
'MR_TPefficiencyDZZ',
),

)



hltMuonPostVal = cms.Sequence(
hltMuonEfficiencies
hltMuonEfficiencies*
hltMuonEfficienciesMR*
hltMuonRefEfficiencies*
hltMuonRefEfficienciesMR
)


Expand Down