-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates on DQMOffline/Trigger for Muons #18968
Conversation
…nly booked for doublemuon
A new Pull Request was created by @sscruz for master. It involves the following packages: DQMOffline/Trigger @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -79,15 +78,19 @@ | |||
## Both 1D and 2D plots use the binnings defined here | |||
binParams = cms.untracked.PSet( | |||
## parameters for fixed-width plots | |||
NVertex = cms.untracked.vdouble( 20, 1, 50), | |||
NVertex = cms.untracked.vdouble( 20, 1, 60), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest you to slightly increase it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To what? 65?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtosi how about ( 20, 1, 100)?
@@ -79,15 +78,19 @@ | |||
## Both 1D and 2D plots use the binnings defined here | |||
binParams = cms.untracked.PSet( | |||
## parameters for fixed-width plots | |||
NVertex = cms.untracked.vdouble( 20, 1, 50), | |||
NVertex = cms.untracked.vdouble( 20, 1, 60), | |||
NVertexFine= cms.untracked.vdouble( 40, 1, 60), | |||
eta = cms.untracked.vdouble( 20, -2.40, 2.40), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldn't you make use of a variable bin width ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenjaminRS Does 0,5 and then from 10 to 55,with a step of 3 sound reasonable?
https://goo.gl/843SVr
ok, these range has been updated for the high PU fill last year ..
but in this plots black and blue are 2017 runs
mia
…On Fri, May 26, 2017 at 6:55 PM, Benjamin Radburn-Smith < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In DQMOffline/Trigger/python/HLTMuonOfflineAnalyzer_cfi.py
<#18968 (comment)>:
> @@ -79,15 +78,19 @@
## Both 1D and 2D plots use the binnings defined here
binParams = cms.untracked.PSet(
## parameters for fixed-width plots
- NVertex = cms.untracked.vdouble( 20, 1, 50),
+ NVertex = cms.untracked.vdouble( 20, 1, 60),
To what? 65?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18968 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt586QVRk-tMmSY617w0QWhrIto4vfsks5r9wP8gaJpZM4NnzWO>
.
|
increase the range !
did you see the plot on the offline DQM ?
mia
…On Fri, May 26, 2017 at 9:32 PM, sscruz ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In DQMOffline/Trigger/python/HLTMuonOfflineAnalyzer_cfi.py
<#18968 (comment)>:
> @@ -79,15 +78,19 @@
## Both 1D and 2D plots use the binnings defined here
binParams = cms.untracked.PSet(
## parameters for fixed-width plots
- NVertex = cms.untracked.vdouble( 20, 1, 50),
+ NVertex = cms.untracked.vdouble( 20, 1, 60),
+ NVertexFine= cms.untracked.vdouble( 40, 1, 60),
eta = cms.untracked.vdouble( 20, -2.40, 2.40),
@BenjaminRS <https://github.com/benjaminrs> Does 0,5 and then from 10 to
55,with a step of 3 sound reasonable?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18968 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt58xiTXrupOE2Bx50G0iwyVUFyUEEKks5r9yiygaJpZM4NnzWO>
.
|
why don't you simply do 100,0,100 ?
… On 26 May 2017, at 21:32, sscruz ***@***.***> wrote:
@sscruz commented on this pull request.
In DQMOffline/Trigger/python/HLTMuonOfflineAnalyzer_cfi.py:
> @@ -79,15 +78,19 @@
## Both 1D and 2D plots use the binnings defined here
binParams = cms.untracked.PSet(
## parameters for fixed-width plots
- NVertex = cms.untracked.vdouble( 20, 1, 50),
+ NVertex = cms.untracked.vdouble( 20, 1, 60),
+ NVertexFine= cms.untracked.vdouble( 40, 1, 60),
eta = cms.untracked.vdouble( 20, -2.40, 2.40),
@BenjaminRS Does 0,5 and then from 10 to 55,with a step of 3 sound reasonable?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Will we have statistics for that? This is to measure efficiencies, not distributions... |
then, make a variable binning
coarse bin size where you are not expecting entries, and finer between 20 and 60, i would say
… On 27 May 2017, at 10:16, sscruz ***@***.***> wrote:
Will we have statistics for that? This is to measure efficiencies, not distributions...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Pull request #18968 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again. |
Please remove member |
Pull request #18968 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@sscruz, I think we need the backport to 92x ... |
thanks !
…On Mon, Jul 3, 2017 at 11:21 AM, sscruz ***@***.***> wrote:
Hi @mtosi <https://github.com/mtosi> , I've added a PR to 92 (#19512
<#19512>)
Cheers!
Sergio
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18968 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt589wDUgPOSifmbJbakWPPMJZCzs_jks5sKLKwgaJpZM4NnzWO>
.
|
merge |
This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top
This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top
This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top
Improvements in muon Trigger Offline DQM: