Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates on DQMOffline/Trigger for Muons #18968

Merged
merged 26 commits into from Jul 4, 2017
Merged

Updates on DQMOffline/Trigger for Muons #18968

Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
550c0c3
Reference trigger efficiency implemented
Apr 15, 2017
7bffe6d
Latest improvements and removing couts
May 1, 2017
435a9a2
Small bugfix
May 2, 2017
af83118
Adding missing add
May 2, 2017
8438bca
Improvements: 2d plots and others
May 19, 2017
50a54ed
Move MR harvesting to a different directory
May 22, 2017
4bd6f53
New single/dimuon paths, fix dz binning, referenceEfficiency histos o…
May 23, 2017
48da751
Removing cout
May 23, 2017
463da56
Fixing DZ histos names
May 23, 2017
39cc108
Removing HLT_L2Mu10 as it's not needed
May 24, 2017
812a91a
Adding DZ vs NVertex plot
May 25, 2017
60a5ecd
Fixing DZ efficiency and adding phi vs eta plot
May 26, 2017
4a2305c
Fix HEP2017 binning
May 26, 2017
1c2f218
Tuning HEP2017 binning
May 26, 2017
52699a4
fixing stupid typo
May 26, 2017
9480c97
Changing nvert binning
sscruz May 27, 2017
35c5609
Changing eta range for reco and hlt muons
sscruz May 29, 2017
d73bfb2
New plots and binnings and paths
May 29, 2017
5b4b522
Changing DQM client
sscruz Jun 1, 2017
3b56bef
Merge branch 'master' into HLT_dev_92v2
sscruz Jun 2, 2017
8d007ce
Fixing HLTMuonRefMethod -> QMEDHarvester
sscruz Jun 6, 2017
70c8039
Create HLTMuonOfflineAnalyzer_cfi.py
sscruz Jun 8, 2017
7a01502
Create HLTMuonOfflineAnalyzer_cfi.py
sscruz Jun 12, 2017
9323f99
Bugfix: name of analyzers has changed
sscruz Jun 12, 2017
70e8db7
Addressing Davids comments
Jun 22, 2017
6cb6a92
Addressing Dmitrijus comment
Jun 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions DQMOffline/Configuration/python/DQMOfflineHeavyIons_cff.py
View file
Open in desktop
Expand Up @@ -85,10 +85,10 @@
hltResults.RecHitsEETag = cms.untracked.InputTag("ecalRecHit", "EcalRecHitsEE")


globalAnalyzer.inputTags.offlinePVs = cms.InputTag("hiSelectedVertex")
trackerAnalyzer.inputTags.offlinePVs = cms.InputTag("hiSelectedVertex")
tightAnalyzer.inputTags.offlinePVs = cms.InputTag("hiSelectedVertex")
looseAnalyzer.inputTags.offlinePVs = cms.InputTag("hiSelectedVertex")
globalAnalyzerTnP.inputTags.offlinePVs = cms.InputTag("hiSelectedVertex")
trackerAnalyzerTnP.inputTags.offlinePVs = cms.InputTag("hiSelectedVertex")
tightAnalyzerTnP.inputTags.offlinePVs = cms.InputTag("hiSelectedVertex")
looseAnalyzerTnP.inputTags.offlinePVs = cms.InputTag("hiSelectedVertex")

pvMonitor.vertexLabel = cms.InputTag("hiSelectedVertex")

Expand Down
4 changes: 3 additions & 1 deletion DQMOffline/Trigger/interface/HLTMuonMatchAndPlot.h
View file
Open in desktop
Expand Up @@ -44,6 +44,7 @@
#include "TNtuple.h"
#include "TString.h"
#include "TPRegexp.h"
#include "TLorentzVector.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @sscruz - this include should not be needed.



//////////////////////////////////////////////////////////////////////////////
Expand All @@ -70,7 +71,8 @@ class HLTMuonMatchAndPlot
void beginRun(DQMStore::IBooker &, const edm::Run &, const edm::EventSetup &);
void analyze(edm::Handle<reco::MuonCollection> &, edm::Handle<reco::BeamSpot> &,
edm::Handle<reco::VertexCollection> &, edm::Handle<trigger::TriggerEvent> &,
edm::Handle<edm::TriggerResults> &);
edm::Handle<edm::TriggerResults> &,
const edm::TriggerNames&);
void endRun(const edm::Run &, const edm::EventSetup &);

// Helper Methods
Expand Down
113 changes: 91 additions & 22 deletions DQMOffline/Trigger/python/HLTMuonOfflineAnalyzer_cff.py
View file
Open in desktop
Expand Up @@ -46,37 +46,106 @@
)


globalAnalyzer = hltMuonOfflineAnalyzer.clone()
globalAnalyzer.destination = "HLT/Muon/DistributionsGlobal"
globalAnalyzer.targetParams = globalMuonParams
#globalAnalyzer.probeParams = cms.PSet()

trackerAnalyzer = hltMuonOfflineAnalyzer.clone()
trackerAnalyzer.destination = "HLT/Muon/DistributionsTracker"
trackerAnalyzer.targetParams = trackerMuonParams
#trackerAnalyzer.probeParams = cms.PSet()

tightAnalyzer = hltMuonOfflineAnalyzer.clone()
tightAnalyzer.destination = "HLT/Muon/DistributionsTight"
tightAnalyzer.targetParams = tightMuonParams
globalAnalyzerTnP = hltMuonOfflineAnalyzer.clone()
globalAnalyzerTnP.destination = "HLT/Muon/DistributionsGlobal"
globalAnalyzerTnP.targetParams = globalMuonParams
#globalAnalyzerTnP.probeParams = cms.PSet()

trackerAnalyzerTnP = hltMuonOfflineAnalyzer.clone()
trackerAnalyzerTnP.destination = "HLT/Muon/DistributionsTracker"
trackerAnalyzerTnP.targetParams = trackerMuonParams
#trackerAnalyzerTnP.probeParams = cms.PSet()

tightAnalyzerTnP = hltMuonOfflineAnalyzer.clone()
tightAnalyzerTnP.destination = "HLT/Muon/DistributionsTight"
tightAnalyzerTnP.targetParams = tightMuonParams
#tightAnalyzerTnP.probeParams = cms.PSet()

looseAnalyzerTnP = hltMuonOfflineAnalyzer.clone()
looseAnalyzerTnP.destination = "HLT/Muon/DistributionsLoose"
looseAnalyzerTnP.targetParams = looseMuonParams
#tightAnalyzer.probeParams = cms.PSet()

looseAnalyzer = hltMuonOfflineAnalyzer.clone()
looseAnalyzer.destination = "HLT/Muon/DistributionsLoose"
looseAnalyzer.targetParams = looseMuonParams

globalAnalyzerRef = hltMuonOfflineAnalyzer.clone()
globalAnalyzerRef.destination = "HLT/Muon/DistributionsGlobal"
globalAnalyzerRef.targetParams = globalMuonParams
globalAnalyzerRef.hltPathsToCheck = cms.vstring(
"HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_v",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v",
"HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_v",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_v",
"HLT_TkMu17_TrkIsoVVL_TkMu8_TrkIsoVVL_v",
"HLT_TkMu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v")
globalAnalyzerRef.requiredTriggers = cms.untracked.vstring(
"HLT_Mu17_TrkIsoVVL_v")

#globalAnalyzerRef.probeParams = cms.PSet()

trackerAnalyzerRef = hltMuonOfflineAnalyzer.clone()
trackerAnalyzerRef.destination = "HLT/Muon/DistributionsTracker"
trackerAnalyzerRef.targetParams = trackerMuonParams
trackerAnalyzerRef.hltPathsToCheck = cms.vstring(
"HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_v",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v",
"HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_v",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_v",
"HLT_TkMu17_TrkIsoVVL_TkMu8_TrkIsoVVL_v",
"HLT_TkMu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v")
trackerAnalyzerRef.requiredTriggers = cms.untracked.vstring(
"HLT_Mu17_TrkIsoVVL_v")
#trackerAnalyzerRef.probeParams = cms.PSet()

tightAnalyzerRef = hltMuonOfflineAnalyzer.clone()
tightAnalyzerRef.destination = "HLT/Muon/DistributionsTight"
tightAnalyzerRef.targetParams = tightMuonParams
tightAnalyzerRef.hltPathsToCheck = cms.vstring(
"HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_v",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v",
"HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_v",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_v",
"HLT_TkMu17_TrkIsoVVL_TkMu8_TrkIsoVVL_v",
"HLT_TkMu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v")
tightAnalyzerRef.requiredTriggers = cms.untracked.vstring(
"HLT_Mu17_TrkIsoVVL_v")
#tightAnalyzerRef.probeParams = cms.PSet()

looseAnalyzerRef = hltMuonOfflineAnalyzer.clone()
looseAnalyzerRef.destination = "HLT/Muon/DistributionsLoose"
looseAnalyzerRef.targetParams = looseMuonParams
looseAnalyzerRef.hltPathsToCheck = cms.vstring(
"HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_v",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v",
"HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_v",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_v",
"HLT_TkMu17_TrkIsoVVL_TkMu8_TrkIsoVVL_v",
"HLT_TkMu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v")
looseAnalyzerRef.requiredTriggers = cms.untracked.vstring(
"HLT_Mu17_TrkIsoVVL_v")
#tightAnalyzer.probeParams = cms.PSet()




hltMuonOfflineAnalyzers = cms.Sequence(
globalAnalyzer *
trackerAnalyzer *
tightAnalyzer *
looseAnalyzer
globalAnalyzerTnP *
trackerAnalyzerTnP *
tightAnalyzerTnP *
looseAnalyzerTnP *
globalAnalyzerRef *
trackerAnalyzerRef *
tightAnalyzerRef *
looseAnalyzerRef
)

from Configuration.Eras.Modifier_pA_2016_cff import pA_2016
for muAna in [globalAnalyzer.targetParams, trackerAnalyzer.targetParams, tightAnalyzer.targetParams, looseAnalyzer.targetParams]:
for muAna in [globalAnalyzerTnP.targetParams, trackerAnalyzerTnP.targetParams,
tightAnalyzerTnP.targetParams, looseAnalyzerTnP.targetParams,
globalAnalyzerRef.targetParams, trackerAnalyzerRef.targetParams,
tightAnalyzerRef.targetParams, looseAnalyzerRef.targetParams,]:
pA_2016.toModify(muAna, ptCut_Jpsi = cms.untracked.double( 5.0))
for muAna in [globalAnalyzer.binParams, trackerAnalyzer.binParams, tightAnalyzer.binParams, looseAnalyzer.binParams]:
for muAna in [globalAnalyzerTnP.binParams, trackerAnalyzerTnP.binParams,
tightAnalyzerTnP.binParams, looseAnalyzerTnP.binParams,
globalAnalyzerRef.binParams, trackerAnalyzerRef.binParams,
tightAnalyzerRef.binParams, looseAnalyzerRef.binParams]:
pA_2016.toModify(muAna, ptCoarse = cms.untracked.vdouble(0.,1.,2.,3.,4.,5.,7.,9.,12.,15.,20.,30.,40.))
31 changes: 24 additions & 7 deletions DQMOffline/Trigger/python/HLTMuonOfflineAnalyzer_cfi.py
View file
Open in desktop
Expand Up @@ -10,14 +10,21 @@

## HLT paths passing any one of these regular expressions will be included
hltPathsToCheck = cms.vstring(
"HLT_Mu8_TrkIsoVVL_v",
"HLT_Mu8_v",
"HLT_Mu17_TrkIsoVVL_v",
"HLT_Mu17_v",
"HLT_TkMu17_v",
"HLT_L2Mu10_v",
"HLT_L1SingleMu25_v",
"HLT_L1SingleMu18_v",
"HLT_Mu17_TrkIsoVVL_v",
"HLT_Mu45_eta2p1_v1",
"HLT_Mu50_v",
"HLT_IsoMu24_v",
"HLT_IsoTkMu24_v",
# "HLT_Mu17_Mu8_DZ_v",
# "HLT_Mu17_TkMu8_DZ_v",
"HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_DZ_v",
"HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_DZ_v",
"HLT_IsoMu20_eta2p1_v",
"HLT_IsoTkMu20_eta2p1_v",
"HLT_IsoMu24_eta2p1_v",
Expand Down Expand Up @@ -79,23 +86,33 @@
## Both 1D and 2D plots use the binnings defined here
binParams = cms.untracked.PSet(
## parameters for fixed-width plots
NVertex = cms.untracked.vdouble( 20, 1, 50),
NVertex = cms.untracked.vdouble( 1,10,15,20,25,30,35,40,45,50,55,60,65,70,100),
NVertexFine= cms.untracked.vdouble( 1,5,10,12.5,15,17.5,20,22.5,25,27.5,30,32.5,35,37.5,40,42.5,45,47.5,50,52.5,55,57.5,60,62.5,65,67.5,70,85,100),
eta = cms.untracked.vdouble( 20, -2.40, 2.40),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't you make use of a variable bin width ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenjaminRS Does 0,5 and then from 10 to 55,with a step of 3 sound reasonable?

phi = cms.untracked.vdouble( 20, -3.14, 3.14),
z0 = cms.untracked.vdouble( 10, -15.00, 15.00),
phiHEP17 = cms.untracked.vdouble( -3.14,-2.4,-1.8,-1.0,-0.4,0.0,0.4,1.0,1.8,2.4,3.14),
z0 = cms.untracked.vdouble( 10, -0.15, 0.15),
z0Fine = cms.untracked.vdouble( 20, -0.15, 0.15),
d0 = cms.untracked.vdouble( 10, -0.50, 0.50),
zMass = cms.untracked.vdouble( 50, 65.00, 115.00),
jpsiMass = cms.untracked.vdouble( 60, 0.00, 6.00),
charge = cms.untracked.vdouble( 2, -2.00, 2.00),
deltaR = cms.untracked.vdouble( 20, 0.00, 0.05),
deltaR2 = cms.untracked.vdouble( 20, 0.0, 4.5 ),
phiCoarse = cms.untracked.vdouble( 10, -3.14, 3.14),
resolutionRel = cms.untracked.vdouble( 40, -0.30, 0.30),
resolutionEta = cms.untracked.vdouble( 20, -0.01, 0.01),
resolutionPhi = cms.untracked.vdouble( 20, -0.01, 0.01),
## parameters for variable-width plots
etaCoarse = cms.untracked.vdouble(-2.4, -2.1, -1.6, -1.2, -0.8, 0.0,
0.8, 1.2, 1.6, 2.1, 2.4),
etaFine = cms.untracked.vdouble(-2.4,-2.1,-1.6,-1.2,-0.9,-0.3,
-0.2,0.2,0.3,0.9,1.2,1.6,2.1,2.4),
phiFine = cms.untracked.vdouble(-3.14,-(11.0/12.0)*3.14,-(9.0/12.0)*3.14,-(7.0/12.0)*3.14,-(5.0/12.0)*3.14,-
(3.0/12.0)*3.14,-(1.0/12.0)*3.14,(1.0/12.0)*3.14,(3.0/12.0)*3.14,(5.0/12.0)*3.14,(7.0/12.0)*3.14,
(9.0/12.0)*3.14,(11.0/12.0)*3.14,3.14),
ptCoarse = cms.untracked.vdouble(10.0, 20.0, 40.0, 60.0, 80.0, 100.0, 200.0),
ptFine = cms.untracked.vdouble(10.0,15.0, 20.0,30.0, 40.0,50.0, 60.0,70.0, 80.0,90.0, 100.0,150., 200.0),
pt = cms.untracked.vdouble( 0.0, 2.0, 4.0,
6.0, 8.0, 10.0,
20.0, 30.0, 40.0,
Expand All @@ -116,7 +133,7 @@
),

## Only events passing all these triggers will be considered
requiredTriggers = cms.untracked.vstring(),
requiredTriggers = cms.untracked.vstring(),

## This collection is used to fill most distributions
targetParams = cms.PSet(
Expand All @@ -137,8 +154,8 @@
d0Cut = cms.untracked.double(2.0),
z0Cut = cms.untracked.double(25.0),
## cuts
recoCuts = cms.untracked.string("isGlobalMuon && abs(eta) < 2.0"),
hltCuts = cms.untracked.string("abs(eta) < 2.0"),
recoCuts = cms.untracked.string("isGlobalMuon && abs(eta) < 2.4"),
hltCuts = cms.untracked.string("abs(eta) < 2.4"),
),

)