New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of isolatedTracks collection in miniAOD to include stopped track information #19025
Conversation
… energy computation
A new Pull Request was created by @bjmarsh (Bennett Marsh) for master. It involves the following packages: DataFormats/PatCandidates @perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 for #19025 56b37c7
|
the analysis signature is still missing. @davidlange6 please check this PR if there is no clarification on analysis signature by tomorrow. |
@davidlange6 |
merge |
@bjmarsh , looks like this PR broke one unit test in last night IB |
On 6/16/17 8:45 AM, Malik Shahzad Muzaffar wrote:
@bjmarsh <https://github.com/bjmarsh>, @slava77
<https://github.com/slava77> any one looking in to this?
yes
it's not even 9am here yet to expect much progress
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19025 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbuFb6DHi_GstTfeKj9mtCYjshTAVks5sEqMzgaJpZM4Nq3b3>.
|
@smuzaffar , fix is in #19303. I ran the unit test you linked to and it seems to work with the update. |
This updates the previously created isolatedTrack collection in miniAOD to include information relevant to stopped track analyses. It still includes all isolated charged PFCandidates, so can be used for vetoes on isolated charged candidates in other analyses.
The collection now draws from the packedPFCandidates, lostTracks, and generalTracks collections. Any track satisfying both the following requirements is saved:
The IsolatedTrack class stores basic kinematic and isolation information, as well as details on the hit pattern in the tracker, dE/dx energy loss in pixels/strips, predicted intersections of the track with calorimeter cells (and the status codes of those calorimeters), and hadronic/EM energy components of nearby calo jets.
Testing on various samples, the size of this collection is as follows: