Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of isolatedTracks collection in miniAOD to include stopped track information #19025

Merged
merged 25 commits into from Jun 15, 2017

Conversation

bjmarsh
Copy link
Contributor

@bjmarsh bjmarsh commented May 30, 2017

This updates the previously created isolatedTrack collection in miniAOD to include information relevant to stopped track analyses. It still includes all isolated charged PFCandidates, so can be used for vetoes on isolated charged candidates in other analyses.

The collection now draws from the packedPFCandidates, lostTracks, and generalTracks collections. Any track satisfying both the following requirements is saved:

  • pT > 5 GeV
  • pT > 20 GeV OR (trackIso < 5GeV || relTrackIso < 0.2 || relMiniTrackIso < 0.2)

The IsolatedTrack class stores basic kinematic and isolation information, as well as details on the hit pattern in the tracker, dE/dx energy loss in pixels/strips, predicted intersections of the track with calorimeter cells (and the status codes of those calorimeters), and hadronic/EM energy components of nearby calo jets.

Testing on various samples, the size of this collection is as follows:

Sample       #/event   bytes/event (% total)
--------------------------------------------
DY           3.7       330 (1.0%)
RelValTTbar  7.5       590 (1.1%)
JetHT        6.1       510 (1.8%)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bjmarsh (Bennett Marsh) for master.

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @JyothsnaKomaragiri, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @cbernet this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented May 30, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 30, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20207/console Started: 2017/05/31 04:50

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2017

Pull request #19025 was updated. @perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Jun 8, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20441/console Started: 2017/06/09 00:39

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Comparison job queued.

@slava77
Copy link
Contributor

slava77 commented Jun 9, 2017

After the update (comparing to CMSSW921 as a baseline in red, inverted compared to the legend on the plots):

all_orig-patvssign919-pat_ttbar13tevpu2017wf10224p0c_max-25 min25 patisolatedtracks_isolatedtracks__dqm_obj_dz
The fraction of the PU tracks or candidates is about 50% now (compared to almost none in the previous version).
I suppose, these can be cleaned up a bit to save some space after some studies in a future PR.

The "fromPV" now reflects the most recent update in the lostTrack parsing: "-1" bin is lower.
all_orig-patvssign919-pat_ttbar13tevpu2017wf10224p0c_patisolatedtracks_isolatedtracks__dqm_obj_frompv

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19025/20441/summary.html

Comparison Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 78 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1867702
  • DQMHistoTests: Total failures: 49405
  • DQMHistoTests: Total nulls: 120
  • DQMHistoTests: Total successes: 1818004
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jun 9, 2017

+1

for #19025 56b37c7

@slava77
Copy link
Contributor

slava77 commented Jun 12, 2017

the analysis signature is still missing.
@monttj please sign or clarify if we should expect a review soon

@davidlange6 please check this PR if there is no clarification on analysis signature by tomorrow.
Thank you.

@slava77
Copy link
Contributor

slava77 commented Jun 13, 2017

@davidlange6
please check this PR or suggest otherwise what should be done before you can.
Thank you.

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 5205a46 into cms-sw:master Jun 15, 2017
@smuzaffar
Copy link
Contributor

@bjmarsh , looks like this PR broke one unit test in last night IB
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc530/CMSSW_9_2_X_2017-06-15-2300/unitTestLogs/TauAnalysis/MCEmbeddingTools
can please check and provide the fix?

@smuzaffar
Copy link
Contributor

@bjmarsh, @slava77 any one looking in to this?

@slava77
Copy link
Contributor

slava77 commented Jun 16, 2017 via email

@bjmarsh
Copy link
Contributor Author

bjmarsh commented Jun 16, 2017

@smuzaffar , fix is in #19303. I ran the unit test you linked to and it seems to work with the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants