GenJetFlavourInfos in MiniAOD and Change in JetFlavour of LightJets to physicsPartons in CMSSW 92X #19048
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
|
|
||
| ak4GenJetFlavourInfos = cms.EDProducer("JetFlavourClustering", | ||
|
There was a problem hiding this comment. it will be easier to maintain if this instead clones from ak4JetFlavourInfos ak4GenJetFlavourInfos = ak4JetFlavourInfos.clone(jets = "ak4GenJetsNoNu") |
||
| jets = cms.InputTag("ak4GenJetsNoNu"), | ||
| bHadrons = cms.InputTag("selectedHadronsAndPartons","bHadrons"), | ||
| cHadrons = cms.InputTag("selectedHadronsAndPartons","cHadrons"), | ||
| partons = cms.InputTag("selectedHadronsAndPartons","physicsPartons"), | ||
| leptons = cms.InputTag("selectedHadronsAndPartons","leptons"), | ||
| jetAlgorithm = cms.string("AntiKt"), | ||
| rParam = cms.double(0.4), | ||
| ghostRescaling = cms.double(1e-18), | ||
| hadronFlavourHasPriority = cms.bool(False) | ||
| ) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| // | ||
| // $Id: GenJetFlavourInfoPreserver.cc,v 1.0 2017/05/18 18:45:45 $ | ||
|
There was a problem hiding this comment. please remove this line. |
||
| // | ||
|
|
||
| /** | ||
| \class pat::GenJetFlavourInfoPreserver GenJetFlavourInfoPreserver.h "PhysicsTools/JetMCAlgos/interface/GenJetFlavourInfoPreserver.h" | ||
| \brief Transfers the JetFlavourInfos from the original GenJets to the slimmedGenJets in MiniAOD | ||
|
|
||
| \author Andrej Saibel | ||
| */ | ||
|
|
||
|
|
||
| #include "FWCore/Framework/interface/Frameworkfwd.h" | ||
| #include "FWCore/Framework/interface/stream/EDProducer.h" | ||
| #include "FWCore/Framework/interface/Event.h" | ||
| #include "FWCore/ParameterSet/interface/ParameterSet.h" | ||
| #include "CommonTools/Utils/interface/StringCutObjectSelector.h" | ||
| #include "DataFormats/Common/interface/Association.h" | ||
| #include "DataFormats/Common/interface/RefToPtr.h" | ||
| #include "DataFormats/PatCandidates/interface/PackedGenParticle.h" | ||
| #include "DataFormats/JetReco/interface/GenJet.h" | ||
|
|
||
| #include "DataFormats/JetReco/interface/Jet.h" | ||
| #include "DataFormats/JetReco/interface/JetCollection.h" | ||
| #include "SimDataFormats/JetMatching/interface/JetFlavourInfo.h" | ||
| #include "SimDataFormats/JetMatching/interface/JetFlavourInfoMatching.h" | ||
| #include "DataFormats/HepMCCandidate/interface/GenParticle.h" | ||
| #include "DataFormats/HepMCCandidate/interface/GenParticleFwd.h" | ||
|
|
||
|
|
||
| namespace pat { | ||
|
|
||
| class GenJetFlavourInfoPreserver : public edm::stream::EDProducer<> { | ||
| public: | ||
| explicit GenJetFlavourInfoPreserver(const edm::ParameterSet & iConfig); | ||
| virtual ~GenJetFlavourInfoPreserver() { } | ||
|
|
||
| virtual void produce(edm::Event & iEvent, const edm::EventSetup & iSetup); | ||
|
There was a problem hiding this comment. please add |
||
|
|
||
| private: | ||
| const edm::EDGetTokenT<edm::View<reco::GenJet> > GenJetsToken_; | ||
|
There was a problem hiding this comment. start local variables and data members with lower case letter. Capitalization is reserved for class names. |
||
| const edm::EDGetTokenT<edm::View<reco::Jet> > slimmedGenJetsToken_; | ||
|
|
||
| const StringCutObjectSelector<reco::GenJet> cut_; | ||
|
|
||
| const edm::EDGetTokenT<reco::JetFlavourInfoMatchingCollection> ak4GenJetFlavourInfosToken_; | ||
|
There was a problem hiding this comment. ak4 prefix should be removed here |
||
| }; | ||
|
|
||
| } // namespace | ||
|
|
||
| pat::GenJetFlavourInfoPreserver::GenJetFlavourInfoPreserver(const edm::ParameterSet & iConfig) : | ||
| GenJetsToken_(consumes<edm::View<reco::GenJet> >(iConfig.getParameter<edm::InputTag>("GenJets"))), | ||
| slimmedGenJetsToken_(consumes<edm::View<reco::Jet> >(iConfig.getParameter<edm::InputTag>("slimmedGenJets"))), | ||
| cut_(iConfig.getParameter<std::string>("cut")), | ||
| ak4GenJetFlavourInfosToken_(consumes<reco::JetFlavourInfoMatchingCollection>(iConfig.getParameter<edm::InputTag>("GenJetFlavourInfos"))) | ||
| { | ||
| produces<reco::JetFlavourInfoMatchingCollection>(); | ||
| } | ||
|
|
||
| void | ||
| pat::GenJetFlavourInfoPreserver::produce(edm::Event & iEvent, const edm::EventSetup & iSetup) { | ||
| using namespace edm; | ||
| using namespace std; | ||
|
|
||
| Handle<View<reco::GenJet> > GenJets; | ||
|
There was a problem hiding this comment. start local variables and data members with lower case letter. Capitalization is reserved for class names. |
||
| iEvent.getByToken(GenJetsToken_, GenJets); | ||
|
|
||
| Handle<View<reco::Jet> > slimmedGenJets; | ||
| iEvent.getByToken(slimmedGenJetsToken_, slimmedGenJets); | ||
|
|
||
| Handle<reco::JetFlavourInfoMatchingCollection> ak4GenJetFlavourInfos; | ||
| iEvent.getByToken(ak4GenJetFlavourInfosToken_,ak4GenJetFlavourInfos); | ||
|
|
||
| auto jetFlavourInfos = std::make_unique<reco::JetFlavourInfoMatchingCollection>(reco::JetRefBaseProd(slimmedGenJets)); | ||
|
|
||
|
|
||
| uint slimmedId = 0; | ||
|
|
||
|
|
||
|
|
||
| for (View<reco::GenJet>::const_iterator it = GenJets->begin(), ed = GenJets->end(); it != ed; ++it) { | ||
|
There was a problem hiding this comment.
auto jetIt = genJets->begin(), jetEnd = genJets->end();
auto jetInfoIt = genJetFlavourInfos->begin();
assert(genJets.size() == genJetFlavourInfos.size());
for(; jetIt != jetEnd; ++jetIt, ++jetInfoIt){
... |
||
| if (!cut_(*it)) continue; | ||
|
There was a problem hiding this comment. The part related to this loop and synchronization with the slimmedJets still needs a rewrite The following comments were not addressed: |
||
|
|
||
| for(reco::JetFlavourInfoMatchingCollection::const_iterator JetInfo = ak4GenJetFlavourInfos->begin(); JetInfo != ak4GenJetFlavourInfos->end();++JetInfo){ | ||
|
|
||
| if((JetInfo - ak4GenJetFlavourInfos->begin()) < (it - GenJets->begin())) continue; | ||
| else if((JetInfo - ak4GenJetFlavourInfos->begin()) > (it - GenJets->begin())) continue; | ||
|
|
||
| (*jetFlavourInfos)[slimmedGenJets->refAt(slimmedId)] = reco::JetFlavourInfo(JetInfo->second.getbHadrons(), JetInfo->second.getcHadrons(), JetInfo->second.getPartons(), JetInfo->second.getLeptons(), JetInfo->second.getHadronFlavour(), JetInfo->second.getPartonFlavour()); | ||
|
There was a problem hiding this comment. please add newlines to improve readability. There was a problem hiding this comment. I don't think that this synchronization with slimmed GenJet indexing via a copy-paste of |
||
|
|
||
| break; | ||
|
|
||
| } | ||
|
|
||
| slimmedId++; | ||
| } | ||
|
|
||
| iEvent.put(std::move(jetFlavourInfos)); | ||
| } | ||
|
|
||
| #include "FWCore/Framework/interface/MakerMacros.h" | ||
| using namespace pat; | ||
| DEFINE_FWK_MODULE(GenJetFlavourInfoPreserver); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,12 @@ | |
| dropSpecific = cms.bool(False), | ||
| ) | ||
|
|
||
| slimmedGenJetsFlavourInfos = cms.EDProducer("GenJetFlavourInfoPreserver", | ||
|
There was a problem hiding this comment. cfi files are not meant for definitions of many types of module instances. Better yet is to implement a fillDescriptions method and let the framework create this file |
||
| GenJets = cms.InputTag("ak4GenJetsNoNu"), | ||
| slimmedGenJets = cms.InputTag("slimmedGenJets"), | ||
| cut = cms.string("pt > 8"), #VERY IMPORTANT: cut needs to be the same as in slimmedGenJets above. | ||
| GenJetFlavourInfos = cms.InputTag("ak4GenJetFlavourInfos") | ||
| ) | ||
|
|
||
| slimmedGenJetsAK8 = cms.EDProducer("PATGenJetSlimmer", | ||
| src = cms.InputTag("ak8GenJetsNoNu"), | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @Andrej-CMS,
I am wondering if commenting out this has any consequences not only in terms of file size but also in other places where HadronAndSelector is being used.
It is because if I understand correctly, without this condition, this will contain all partons including status 2 and also stable final particles. That will be a lot of particles. This will also introduce ambiguity issue.
Best Regards,
Taejeong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @monttj ,
These changes were requested by the QGL Group, i.e. Paolo Azzuri. Unfortunately, I cannot find him on GitHub to comment on this.
You are right, the physicspartons will contain the whole chain. I will provide RelVal comparisons as soon as possible.
Kind regards,
Andrej
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make that configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I will do that.
Kind regards,
Andrej