Add missing forward decls to SimG4Forward.

[Teemperor]

In TotemSD.h we need a forward declaration for SimTrackManager
because a we use a ptr to this class in the constructor.

In CastorTestAnalysis.h we need to have a forward declaration to
CaloG4HitCollection because we use a ptr to this class in the
getCastorBranchData signature.

[Teemperor]

Part of the work going on regarding issue #15248

[cmsbuild]

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

SimG4CMS/Forward

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20389/console Started: 2017/06/07 10:27

[cmsbuild]

-1

Tested at: ee73c23

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19126/20389/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

• Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-06-2300/src/Utilities/StaticAnalyzers/src/ThrUnsafeFCallChecker.cpp 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-06-2300/src/Utilities/StaticAnalyzers/src/ClangCmsCheckerPluginRegister.cpp 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-06-2300/src/Utilities/StaticAnalyzers/src/CmsSupport.cpp 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-06-2300/src/Utilities/StaticAnalyzers/src/CatchAll.cpp 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-06-2300/src/SimG4CMS/Forward/src/CastorTestAnalysis.cc:17:0:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-06-2300/src/SimG4CMS/Forward/interface/CastorTestAnalysis.h:64:7: error: using typedef-name 'CaloG4HitCollection' after 'class'
 class CaloG4HitCollection;
       ^
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-06-2300/src/SimG4CMS/Forward/src/CastorTestAnalysis.cc:13:0:
/cvmfs/cms-ib.cern.ch/nweek-02475/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-06-06-2300/src/SimG4CMS/Calo/interface/CaloG4HitCollection.h:11:38: note: 'CaloG4HitCollection' has a previous declaration here
 typedef G4THitsCollection CaloG4HitCollection;


• Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 64 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

           ^
/cvmfs/cms-ib.cern.ch/nweek-02475/slc6_amd64_gcc530/external/geant4/10.02.p02-mlhled2/include/Geant4/G4ParticleDefinition.hh:109:44: note: expanded from macro 'G4MT_pmanager'
#define G4MT_pmanager ((subInstanceManager.offset[g4particleDefinitionInstanceID]).theProcessManager)
                                           ^
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-06-2300/src/SimG4CMS/Forward/src/CastorTestAnalysis.cc:17:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-06-2300/src/SimG4CMS/Forward/interface/CastorTestAnalysis.h:64:7: error: definition of type 'CaloG4HitCollection' conflicts with typedef of the same name
class CaloG4HitCollection;
      ^
/cvmfs/cms-ib.cern.ch/nweek-02475/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-06-06-2300/src/SimG4CMS/Calo/interface/CaloG4HitCollection.h:11:38: note: 'CaloG4HitCollection' declared here
typedef G4THitsCollection CaloG4HitCollection;
                                     ^


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[civanch]

@Teemperor , please, close this PR, #19170 include these fixes