Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr92x L1T uGT emulation M_T and diObjectPT #19155

Merged

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Jun 9, 2017

pr92x L1T uGT emulation M_T and diObjectPT.

This had to wait for the UTM 0.6.3 to be merged, now part of CMSSW_9_2_1.

Needed for data taking, by ECAL AlCa paths that seed with L1T M_T algorithms.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

A new Pull Request was created by @rekovic for master.

It involves the following packages:

CondFormats/L1TObjects
L1Trigger/L1TGlobal
L1Trigger/L1TMuon

@ghellwig, @arunhep, @cerminar, @cmsbuild, @rekovic, @franzoni, @ggovi, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @kreczko, @tocheng, @Martin-Grunewald, @thomreis, @mmusich, @seemasharmafnal this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor Author

rekovic commented Jun 9, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20442/console Started: 2017/06/09 02:17

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19155/20442/summary.html

Comparison Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1867702
  • DQMHistoTests: Total failures: 49471
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1818058
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@rekovic
Copy link
Contributor Author

rekovic commented Jun 9, 2017

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19155/20518/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1817858
  • DQMHistoTests: Total failures: 19306
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1798386
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #19155 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @rekovic, @franzoni, @ggovi, @mulhearn, @davidlange6 can you please check and sign again.

@rekovic
Copy link
Contributor Author

rekovic commented Jun 13, 2017

@davidlange6
In last commit, used enum instead of string as arguments to member functions, as requested.

@rekovic
Copy link
Contributor Author

rekovic commented Jun 13, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20538/console Started: 2017/06/13 17:01

@rekovic
Copy link
Contributor Author

rekovic commented Jun 13, 2017

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19155/20538/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1817858
  • DQMHistoTests: Total failures: 34647
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1783045
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@davidlange6
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants