New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx85 Correct for overwriting (as reported in PR #19179) #19198
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -568,8 +568,8 @@ void HGCalImagingAlgo::computeThreshold() { | |
else if( thickness>299. && thickness<301. ) thickIndex=2; | ||
else assert( thickIndex>0 && "ERROR - silicon thickness has a nonsensical value" ); | ||
float sigmaNoise = 0.001 * fcPerEle * nonAgedNoises[thickIndex] * dEdXweights[layer] / (fcPerMip[thickIndex] * thicknessCorrection[thickIndex]); | ||
thresholds[layer-1][wafer]=sigmaNoise*ecut; | ||
v_sigmaNoise[layer-1][wafer] = sigmaNoise; | ||
thresholds[layer-1].at(wafer)=sigmaNoise*ecut; | ||
v_sigmaNoise[layer-1].at(wafer) = sigmaNoise; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. now that the problem was fixed, please change back to the faster "[]" version There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if protection is really needed for out-of bound reads, please add an |
||
} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the text in the comments above: it still says 794. If instead this 796 corresponds to 794 precisely, please add a few words why.