Wprime dqm prompt monitoring

[gomber]

Hi All,

I have added Exotica Wprime paths for DQM prompt monitoring.
JIRA for these paths : https://its.cern.ch/jira/browse/CMSHLT-1379
This PR needs to run on top of #19119.

Regards
Bhawna

[fwyzard]

@davidlange6, since I missed the ORP today, anything holding up this PR ?

@gomber, do we have a 9.2.x backport ?

[davidlange6]

It's looks to be in my queue at this point Cheers, David On 6 Jul 2017, at 20:35, Andrea Bocci <notifications@github.com<mailto:notifications@github.com>> wrote: @davidlange6<https://github.com/davidlange6>, since I missed the ORP today, anything holding up this PR ? @gomber<https://github.com/gomber>, do we have a 9.2.x backport ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#19250 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzywwUpaZx4OP2Yw8JudMl2UN_GJ_Fwks5sLSjvgaJpZM4N7UYV>.

[davidlange6]

-1
@gomber - please rebase

[fwyzard]

Please merge #19684 which includes this and fixes conflicts.

[fwyzard]

@davidlange6 do you have any comments for this PR, apart from the needed rebase ?

[davidlange6]

hi @fwyzard - this one is like #19290

[fwyzard]

hi @davidlange6,
I've merged this PR with the latest IB, fixed the conflicts, and pushed it to #19891 .
I'll try to address there any comments.

[fwyzard]

(please keep this PR open and as-is until #19891 is merged)

[fwyzard]

@gomber , after merging these changes we run into the error

----- Begin Fatal Exception 26-Jul-2017 06:13:29 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing  Event run: 297227 lumi: 9 event: 991726 stream: 3
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module TopMonitor/'WprimeEle115'
Exception Message:
A std::exception was thrown.
no method or data member named "deltaEtaSuperClusterAtVtx" found for type "reco::GsfElectron"
----- End Fatal Exception -------------------------------------------------
```, because the `reco::GsfElectron` method is called `deltaEtaSuperClusterTrackAtVtx`, not `deltaEtaSuperClusterAtVtx`.

I've fixed it in #19918 - but can I please ask to actually run the code and produce the plots, before submitting the PRs ?

[gomber]

@fwyzard Sorry I am away for 2 weeks. So saw your mails/comments on github now.
I see you already created the new PR with this fix (sorry for having the wrong name there for the function).

In #19918, I see the comparison jobs are ready and tests are approved. In any case I am also running it to amke sure it doesn't show any issue there.

Regards
Bhawna

[fwyzard]

hi Bhawna,
Martin reported also a different problem which I have not been able to reproduce yet:

Begin processing the 5th record. Run 1, Event 107, LumiSection 3 at 26-Jul-2017 10:09:21.725 CEST
----- Begin Fatal Exception 26-Jul-2017 10:09:21 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing  Event run: 1 lumi: 3 event: 103 stream: 0
   [1] Running path 'dqmofflineOnPAT_step'
   [2] Calling method for module TopMonitor/'WprimeEle115'
Exception Message:
A std::exception was thrown.
no method or data member named "passConversionVeto" found for type "reco::GsfElectron"
----- End Fatal Exception -------------------------------------------------

Can you check if you understand where it comes from, and suggest a fix ?

[fwyzard]

@gomber , it is clear that these changes were never tested locally.

I will make a PR to remove these changes from 9.3.x.
I was about to say that the monitored paths will also be immediately removed from the online and MC HLT menus:

• HLT_Ele115_CaloIdVT_GsfTrkIdT_v*
• HLT_Ele135_CaloIdVT_GsfTrkIdT_v*
• HLT_Ele145_CaloIdVT_GsfTrkIdT_v*
• HLT_Ele200_CaloIdVT_GsfTrkIdT_v*
• HLT_Ele250_CaloIdVT_GsfTrkIdT_v*
• HLT_Ele300_CaloIdVT_GsfTrkIdT_v*

However it looks like we already have an independent monitoring implemented by Sam. I that is deemed satisfactory, the triggers can stay. If that is insufficient, the triggers will be removed.

From this moment on, we will request the developers to attach the DQM .root file produced by the proposed code and python changes, before considering the DQM as "good enough" to include the triggers in the menu.

[fwyzard]

This is being reverted by #19937