-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dqm single electron jet #19290
Dqm single electron jet #19290
Conversation
adding variable binning + multiplicity histograms
Updated Leptonic Paths
Merge from fully hadronic
Merge from fully hadronic
Added Reference Monitoring
Update top hlt dqm code to include PV cuts to be used by higgs montoring
@parbol, this PR has automatically been moved to CMSSW 9.3.x . |
@parbol while waiting for your DQM review - there is now a base class appropriate for your new modules available at https://github.com/cms-sw/cmssw/blob/master/DQMOffline/Trigger/plugins/TriggerDQMBase.h. Please have a look and adapt your module. In addition to removing code duplication, you will have addressed a number of the "usual" comments on PRs like this one likely resulting in a faster review. (also your PR is not mergeable) |
@dmitrijus do you have any comments for this PR ? I plan to include it in a second "merged" PR to fix the various conflicts. |
|
||
TopMonitor::~TopMonitor() | ||
{ | ||
if (num_genTriggerEventFlag_) num_genTriggerEventFlag_.reset(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to explicitly reset the unique_ptr. It will be done automatically once unique_ptr will be destroyed.
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
Please do not rebase this. |
@davidlange6 do you have any comments for this PR, apart from the needed rebase ? |
Conflicts: DQMOffline/Trigger/python/SusyMonitoring_Client_cff.py DQMOffline/Trigger/python/SusyMonitoring_cff.py
hi @davidlange6, I have done a minimal clean up, splitting two large python files, and pushed it to #19891 . |
(please keep this PR open and as-is until #19891 is merged) |
@parbol , after merging this PR (via #19891) we are seeing errors like
Looking at DQMOffline/Trigger/python/susyHLTEleCaloJets_cff.py (where I moved the definition of the SUSY electron_jet cross-trigger plots) I see that multiple modules re-use the same folders:
Is it intended ? |
If the aim is to use different folders (and/or the same binning), can you make a PR to fix it, based on the latest 9.3.x IB ? |
This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top
This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top
This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top
This PR adds the monitoring for the singleElectron_PFJet triggers used to collect fake-rate control sample. It uses the code proposed in: #19119 by the top PAG, in the corresponding SusyMonitoring configuration files.