Dqm single electron jet #19290

parbol · 2017-06-16T14:07:13Z

This PR adds the monitoring for the singleElectron_PFJet triggers used to collect fake-rate control sample. It uses the code proposed in: #19119 by the top PAG, in the corresponding SusyMonitoring configuration files.

adding variable binning + multiplicity histograms

Updated Leptonic Paths

Merge from fully hadronic

Added Reference Monitoring

Update top hlt dqm code to include PV cuts to be used by higgs montoring

fwyzard · 2017-07-02T09:07:59Z

@parbol, this PR has automatically been moved to CMSSW 9.3.x .
After fixing the merge conflict, can you make a new PR for CMSSW 9.2.x ?

davidlange6 · 2017-07-05T16:17:37Z

@parbol while waiting for your DQM review - there is now a base class appropriate for your new modules available at https://github.com/cms-sw/cmssw/blob/master/DQMOffline/Trigger/plugins/TriggerDQMBase.h. Please have a look and adapt your module. In addition to removing code duplication, you will have addressed a number of the "usual" comments on PRs like this one likely resulting in a faster review.

(also your PR is not mergeable)

fwyzard · 2017-07-12T09:12:07Z

@dmitrijus do you have any comments for this PR ?
@davidlange6 do you have any comments for this PR ?

I plan to include it in a second "merged" PR to fix the various conflicts.

dmitrijus · 2017-07-13T08:45:55Z

DQMOffline/Trigger/plugins/TopMonitor.cc

+
+TopMonitor::~TopMonitor()
+{
+    if (num_genTriggerEventFlag_) num_genTriggerEventFlag_.reset();


You don't need to explicitly reset the unique_ptr. It will be done automatically once unique_ptr will be destroyed.

dmitrijus · 2017-07-13T08:48:07Z

+1
Made a small comment for the code, but it can be merged.

cmsbuild · 2017-07-13T08:48:27Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

fwyzard · 2017-07-13T08:51:19Z

Please do not rebase this.
As soon as @dmitrijus (done) and @davidlange6 let me know that the PR is fine (apart from the conflict) I will fix it in a separate PR.

fwyzard · 2017-07-23T16:33:21Z

@davidlange6 do you have any comments for this PR, apart from the needed rebase ?

davidlange6 · 2017-07-24T08:06:22Z

hi @fwyzard - i don't really know what should be reviewed - can you identify the commits? if its just the 3 from @parbol - then it would be easy to proceed from a rebase removing the other 80% of content

Conflicts: DQMOffline/Trigger/python/SusyMonitoring_Client_cff.py DQMOffline/Trigger/python/SusyMonitoring_cff.py

fwyzard · 2017-07-24T20:05:35Z

hi @davidlange6,
once rebased on top of the current 9.3.x IB, this PR touches only python files.

I have done a minimal clean up, splitting two large python files, and pushed it to #19891 .

fwyzard · 2017-07-24T20:07:28Z

(please keep this PR open and as-is until #19891 is merged)

fwyzard · 2017-07-25T17:37:11Z

@parbol , after merging this PR (via #19891) we are seeing errors like

----- Begin Fatal Exception 25-Jul-2017 14:24:05 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing  stream end Run run: 297227 stream: 3
   [1] Calling method for module TopMonitor/'susyEle17CaloIdMJet30_ele'
   Additional Info:
      [a] Fatal Root Error: @SUB=Merge
Cannot merge histograms - limits are inconsistent:
 first: elePtEta_1_denominator (9, 0.000000, 400.000000), second: elePtEta_1_denominator (10, 0.000000, 400.000000)

----- End Fatal Exception -------------------------------------------------

Looking at DQMOffline/Trigger/python/susyHLTEleCaloJets_cff.py (where I moved the definition of the SUSY electron_jet cross-trigger plots) I see that multiple modules re-use the same folders:

susyEle8CaloJet30_jet.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/JetMonitor')
susyEle8CaloJet30_ele.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/ElectronMonitor')
susyEle8CaloJet30_all.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/GlobalMonitor')
susyEle8CaloIdMJet30_jet.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/JetMonitor')
susyEle8CaloIdMJet30_ele.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/ElectronMonitor')
susyEle8CaloIdMJet30_all.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/GlobalMonitor')
susyEle12CaloJet30_jet.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/JetMonitor')
susyEle12CaloJet30_ele.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/ElectronMonitor')
susyEle12CaloJet30_all.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/GlobalMonitor')
susyEle17CaloIdMJet30_jet.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/JetMonitor')
susyEle17CaloIdMJet30_ele.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/ElectronMonitor')
susyEle17CaloIdMJet30_all.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/GlobalMonitor')
susyEle23CaloJet30_jet.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/JetMonitor')
susyEle23CaloJet30_ele.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/ElectronMonitor')
susyEle23CaloJet30_all.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/GlobalMonitor')
susyEle23CaloIdMJet30_jet.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/JetMonitor')
susyEle23CaloIdMJet30_ele.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/ElectronMonitor')
susyEle23CaloIdMJet30_all.FolderName = cms.string('HLT/SusyHLTOffline/SusyMonitor/EleJet/GlobalMonitor')

Is it intended ?
Won't this cause the different modules to fill the same histograms multiple times (and possibly lead to conflicts if the binning is different) ?

fwyzard · 2017-07-25T17:40:10Z

If the aim is to use different folders (and/or the same binning), can you make a PR to fix it, based on the latest 9.3.x IB ?

fwyzard · 2017-07-25T21:57:34Z

@parbol, can you check if #19912 fixes this in the intended way ?

fix for #19290

This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top

defranchis and others added 30 commits May 27, 2017 10:36

Offline DQM for Top HLT

b8c78ae

adding electron isolation for ele+jets

552890e

adding variable binning + multiplicity histograms

8173416

Merge pull request cms-sw#5 from defranchis/DQM-try-to-cherrypick

01b00c3

adding variable binning + multiplicity histograms

adding 2D histograms and efficiencies

b68cbb0

renaming directories

26414c6

updating from EDAnalyzer to DQMEDHarvester

5303a4a

adding further 2D distributions for di-lepton channel

7ae70ef

configuring variable binning

3003514

bug fix

f35341a

updating selection for ele+jets

6286bc3

updating pt binnings

5fbdb04

Updated Leptonic Paths

7735713

Reverted changes in HLTriggerOffline

bb8267c

Merge pull request cms-sw#9 from mohsinwaseem/Test

dd87c03

Updated Leptonic Paths

merging code for fully-hadronic

cf5a011

adding default CSV working point

5611aef

Merge pull request cms-sw#10 from defranchis/merge-from-fully-hadronic

1b97155

Merge from fully hadronic

update top hlt dqm code to include PV cuts to be used by higgs montoring

61e8d65

adding string selection for b-jets

79cfa0e

removing single top and updating output directories

5f380f1

optimization and bug fix

0ae26fa

Merge pull request cms-sw#12 from defranchis/merge-from-fully-hadronic

29ea8cc

Merge from fully hadronic

Merge branch 'TopDQMOfflineHLT' into updateTotopdqm

40849d4

resolving conflicts with previous updates from bjet

c817647

Added Reference Monitoring

c7e5018

Merged refs/pull/18981/head from repository cms-sw

3b6908a

adding BTagMu and PFJet monitorning for AK4 and AK8

b8f531d

Merge pull request cms-sw#13 from marinakolosova/newPR_fullyhadronic

5b9627b

Added Reference Monitoring

Merge pull request cms-sw#11 from sroychow/updateTotopdqm

a0f4163

Update top hlt dqm code to include PV cuts to be used by higgs montoring

fwyzard added a commit to fwyzard/cmssw that referenced this pull request Jul 11, 2017

Merge pull request cms-sw#19290 from parbol:DQM-SingleElectron-Jet

8a700d2

fwyzard mentioned this pull request Jul 11, 2017

HLT DQM for 9.3.x #19684

Closed

dmitrijus reviewed Jul 13, 2017

View reviewed changes

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jul 13, 2017

davidlange6 mentioned this pull request Jul 24, 2017

Wprime dqm prompt monitoring #19250

Merged

fwyzard added a commit to fwyzard/cmssw that referenced this pull request Jul 24, 2017

Merge pull request cms-sw#19290 from parbol:DQM-SingleElectron-Jet

e04a469

Conflicts: DQMOffline/Trigger/python/SusyMonitoring_Client_cff.py DQMOffline/Trigger/python/SusyMonitoring_cff.py

fwyzard mentioned this pull request Jul 24, 2017

HLT DQM for 9.3.x - part 3 #19891

Merged

cmsbuild merged commit ba1b6d5 into cms-sw:master Jul 25, 2017

fwyzard mentioned this pull request Jul 25, 2017

fix for #19290 #19912

Merged

davidlange6 added a commit that referenced this pull request Jul 26, 2017

Merge pull request #19912 from fwyzard/HLT_DQM_for_93x_part3_fix

7718720

fix for #19290

fwyzard mentioned this pull request Jul 28, 2017

backport HLT DQM for menu v2.1 to CMSSW 9.2.x #19961

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dqm single electron jet #19290

Dqm single electron jet #19290

parbol commented Jun 16, 2017

fwyzard commented Jul 2, 2017

davidlange6 commented Jul 5, 2017

fwyzard commented Jul 12, 2017

dmitrijus Jul 13, 2017 •

edited

Loading

dmitrijus commented Jul 13, 2017

cmsbuild commented Jul 13, 2017

fwyzard commented Jul 13, 2017

fwyzard commented Jul 23, 2017

davidlange6 commented Jul 24, 2017

fwyzard commented Jul 24, 2017

fwyzard commented Jul 24, 2017

fwyzard commented Jul 25, 2017 •

edited

Loading

fwyzard commented Jul 25, 2017

fwyzard commented Jul 25, 2017

Dqm single electron jet #19290

Dqm single electron jet #19290

Conversation

parbol commented Jun 16, 2017

fwyzard commented Jul 2, 2017

davidlange6 commented Jul 5, 2017

fwyzard commented Jul 12, 2017

dmitrijus Jul 13, 2017 • edited Loading

Choose a reason for hiding this comment

dmitrijus commented Jul 13, 2017

cmsbuild commented Jul 13, 2017

fwyzard commented Jul 13, 2017

fwyzard commented Jul 23, 2017

davidlange6 commented Jul 24, 2017

fwyzard commented Jul 24, 2017

fwyzard commented Jul 24, 2017

fwyzard commented Jul 25, 2017 • edited Loading

fwyzard commented Jul 25, 2017

fwyzard commented Jul 25, 2017

dmitrijus Jul 13, 2017 •

edited

Loading

fwyzard commented Jul 25, 2017 •

edited

Loading