Fixing the statistics for MultiRunHarvesting #19400

dimattia · 2017-06-21T17:14:41Z

Greetings,

the main purpose of this pull request is to raise the threshold on the total amount of clusters that have to be collected before fitting the APV cluster charge thus producing the gain payload. The change consists of a setting of a parameter in two python filles.

Since the cluster statistics affects the precision of the gain payload, it is important to have this PR merged in the main branch and to have it delivered at Tier0 asap. indeed it impacts the gain computation in the MRH framework. The framework that uses the calibration ntuple is not affected by this one, because - in this case - the input statistic is handled manually.

In addition to the statistic fix, the fill of some monitoring histogram has been protected against the inclusion of statistics from the Pixel detector. This change concerns the inclusion of an if statement into two .cc files.

cmsbuild · 2017-06-21T17:15:01Z

A new Pull Request was created by @dimattia for master.

It involves the following packages:

CalibTracker/SiStripChannelGain

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @gbenelli, @tocheng, @jlagram, @OlivierBondu, @mmusich this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

arunhep · 2017-06-21T21:43:33Z

please test

cmsbuild · 2017-06-21T21:43:50Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20824/console Started: 2017/06/21 23:44

cmsbuild · 2017-06-21T22:10:07Z

-1

Tested at: 3197178

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19400/20824/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

27434.0 step3

runTheMatrix-results/27434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

23234.0 step3

runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D18_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D18+RecoFullGlobal_2023D18+HARVESTFullGlobal_2023D18/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D18_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D18+RecoFullGlobal_2023D18+HARVESTFullGlobal_2023D18.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Thu Jun 22 00:01:59 2017-date Thu Jun 22 00:01:54 2017 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 22 00:02:45 2017-date Thu Jun 22 00:01:58 2017 s - exit: 256
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 22 00:04:11 2017-date Thu Jun 22 00:02:00 2017 s - exit: 256
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Thu Jun 22 00:08:41 2017-date Thu Jun 22 00:02:04 2017 s - exit: 256
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns --magField 38T_PostLS1 : FAILED - time: date Thu Jun 22 00:02:11 2017-date Thu Jun 22 00:02:06 2017 s - exit: 256
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Thu Jun 22 00:09:00 2017-date Thu Jun 22 00:02:08 2017 s - exit: 256
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Thu Jun 22 00:02:15 2017-date Thu Jun 22 00:02:10 2017 s - exit: 256
cmsDriver.py RelVal -s HLT:GRun2016,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun2016 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun2016_MC.root --fileout file:RelVal_Raw_GRun2016_MC_HLT_RECO.root : FAILED - time: date Thu Jun 22 00:09:11 2017-date Thu Jun 22 00:02:12 2017 s - exit: 256
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 22 00:04:03 2017-date Thu Jun 22 00:02:17 2017 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Thu Jun 22 00:07:54 2017-date Thu Jun 22 00:02:22 2017 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Thu Jun 22 00:07:48 2017-date Thu Jun 22 00:02:29 2017 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Thu Jun 22 00:08:01 2017-date Thu Jun 22 00:02:34 2017 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 22 00:03:31 2017-date Thu Jun 22 00:02:40 2017 s - exit: 256
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 22 00:05:20 2017-date Thu Jun 22 00:02:41 2017 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 22 00:03:46 2017-date Thu Jun 22 00:02:44 2017 s - exit: 256
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Thu Jun 22 00:08:33 2017-date Thu Jun 22 00:02:46 2017 s - exit: 256
cmsDriver.py RelVal -s HLT:GRun2016,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun2016 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun2016_DATA.root --fileout file:RelVal_Raw_GRun2016_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 22 00:07:07 2017-date Thu Jun 22 00:02:49 2017 s - exit: 256

cmsbuild · 2017-06-21T22:10:10Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

mmusich · 2017-06-22T08:19:16Z

The errors that show up in most tested workflows:

Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/nweek-02477/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-06-21-1100/bin/slc6_amd64_gcc530/cmsDriver.py", line 55, in <module>
    run()
  File "/cvmfs/cms-ib.cern.ch/nweek-02477/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-06-21-1100/bin/slc6_amd64_gcc530/cmsDriver.py", line 27, in run
    configBuilder.prepare()
  File "/cvmfs/cms-ib.cern.ch/nweek-02477/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-06-21-1100/python/Configuration/Applications/ConfigBuilder.py", line 2052, in prepare
    self.addStandardSequences()
  File "/cvmfs/cms-ib.cern.ch/nweek-02477/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-06-21-1100/python/Configuration/Applications/ConfigBuilder.py", line 744, in addStandardSequences
    getattr(self,"prepare_"+stepName)(sequence = getattr(self,stepName+"DefaultSeq"))
  File "/cvmfs/cms-ib.cern.ch/nweek-02477/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-06-21-1100/python/Configuration/Applications/ConfigBuilder.py", line 1642, in prepare_RECO
    self.loadDefaultOrSpecifiedCFF(sequence,self.RECODefaultCFF)
  File "/cvmfs/cms-ib.cern.ch/nweek-02477/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-06-21-1100/python/Configuration/Applications/ConfigBuilder.py", line 1185, in loadDefaultOrSpecifiedCFF
    l=self.loadAndRemember(defaultCFF)
  File "/cvmfs/cms-ib.cern.ch/nweek-02477/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-06-21-1100/python/Configuration/Applications/ConfigBuilder.py", line 321, in loadAndRemember
    self.process.load(includeFile)
  File "/cvmfs/cms-ib.cern.ch/nweek-02477/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-06-21-1100/python/FWCore/ParameterSet/Config.py", line 582, in load
    module = __import__(moduleName)
  File "/cvmfs/cms-ib.cern.ch/nweek-02477/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-06-21-1100/python/FastSimulation/Configuration/Reconstruction_AftMix_cff.py", line 14, in <module>
    import Configuration.StandardSequences.Reconstruction_cff as _reco
  File "/cvmfs/cms-ib.cern.ch/nweek-02477/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-06-21-1100/python/Configuration/StandardSequences/Reconstruction_cff.py", line 35, in <module>
    from RecoLocalTracker.Configuration.RecoLocalTracker_cff import *
  File "/cvmfs/cms-ib.cern.ch/nweek-02477/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-06-21-1100/python/RecoLocalTracker/Configuration/RecoLocalTracker_cff.py", line 21, in <module>
    from RecoLocalTracker.Phase2ITPixelClusterizer.Phase2ITPixelClusterizer_cfi import *
ImportError: No module named Phase2ITPixelClusterizer.Phase2ITPixelClusterizer_cfi

are not related tot the specific code changes in this PR.
In fact the IB used to perform the tests (CMSSW_9_2_X_2017-06-21-1100) appears to be broken: https://cms-sw.github.io/relvalLogDetail.html#slc7_aarch64_gcc530;CMSSW_9_2_X_2017-06-21-2300
@smuzaffar

boudoul · 2017-06-22T08:22:54Z

It will be fixed in the next IB

cerminar · 2017-06-22T08:32:16Z

please test

cmsbuild · 2017-06-22T08:32:34Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20829/console Started: 2017/06/22 10:34

mmusich · 2017-06-22T08:37:14Z

@cerminar, thanks, but if I am not mistaken reading the jenkins console output https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20829/console
we're still being tested agains CMSSW_9_2_X_2017-06-21-2300, while the first IB with the fix from @boudoul is CMSSW_9_2_X_2017-06-22-1000

smuzaffar · 2017-06-22T08:40:59Z

please abort
10h00 is not yet ready. I will trigger the Pr tests for this once the IB is ready.

cmsbuild · 2017-06-22T21:30:13Z

Pull request #19400 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please check and sign again.

dimattia · 2017-06-22T21:35:26Z

@ davidlange6

I implemented your suggestion as it improves the readability of the code.

arunhep · 2017-06-22T21:46:19Z

please test

cmsbuild · 2017-06-22T21:46:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20858/console Started: 2017/06/22 23:47

cmsbuild · 2017-06-22T22:41:16Z

+1
Tested at: 7de94d0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19400/20858/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e0be6a0
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19400/20858/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19400/20858/git-merge-result

cmsbuild · 2017-06-22T22:41:20Z

Comparison job queued.

cmsbuild · 2017-06-23T01:00:08Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19400/20858/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1802848
DQMHistoTests: Total failures: 15022
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1787660
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

arunhep · 2017-06-23T11:03:21Z

+1

cmsbuild · 2017-06-23T11:03:35Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-06-23T11:47:31Z

+1

Fixing the statistics for MultiRunHarvesting

3197178

cmsbuild added this to the CMSSW_9_2_X milestone Jun 21, 2017

cmsbuild added alca-pending comparison-pending orp-pending pending-signatures tests-pending labels Jun 21, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 21, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jun 21, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Jun 22, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 22, 2017

cmsbuild added alca-pending comparison-pending pending-signatures tests-pending and removed comparison-available fully-signed tests-approved labels Jun 22, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 22, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 22, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 23, 2017

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Jun 23, 2017

cmsbuild added orp-approved and removed orp-pending labels Jun 23, 2017

cmsbuild merged commit 768d640 into cms-sw:master Jun 23, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing the statistics for MultiRunHarvesting #19400

Fixing the statistics for MultiRunHarvesting #19400

dimattia commented Jun 21, 2017

cmsbuild commented Jun 21, 2017

arunhep commented Jun 21, 2017

cmsbuild commented Jun 21, 2017 •

edited

cmsbuild commented Jun 21, 2017

cmsbuild commented Jun 21, 2017

mmusich commented Jun 22, 2017

boudoul commented Jun 22, 2017

cerminar commented Jun 22, 2017

cmsbuild commented Jun 22, 2017 •

edited

mmusich commented Jun 22, 2017

smuzaffar commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

dimattia commented Jun 22, 2017

arunhep commented Jun 22, 2017

cmsbuild commented Jun 22, 2017 •

edited

cmsbuild commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

cmsbuild commented Jun 23, 2017

arunhep commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

davidlange6 commented Jun 23, 2017

Fixing the statistics for MultiRunHarvesting #19400

Fixing the statistics for MultiRunHarvesting #19400

Conversation

dimattia commented Jun 21, 2017

cmsbuild commented Jun 21, 2017

arunhep commented Jun 21, 2017

cmsbuild commented Jun 21, 2017 • edited

cmsbuild commented Jun 21, 2017

cmsbuild commented Jun 21, 2017

mmusich commented Jun 22, 2017

boudoul commented Jun 22, 2017

cerminar commented Jun 22, 2017

cmsbuild commented Jun 22, 2017 • edited

mmusich commented Jun 22, 2017

smuzaffar commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

dimattia commented Jun 22, 2017

arunhep commented Jun 22, 2017

cmsbuild commented Jun 22, 2017 • edited

cmsbuild commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

cmsbuild commented Jun 23, 2017

arunhep commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

davidlange6 commented Jun 23, 2017

cmsbuild commented Jun 21, 2017 •

edited

cmsbuild commented Jun 22, 2017 •

edited

cmsbuild commented Jun 22, 2017 •

edited