Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the statistics for MultiRunHarvesting #19400

Merged
merged 2 commits into from Jun 23, 2017
Merged

Fixing the statistics for MultiRunHarvesting #19400

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3197178
Fixing the statistics for MultiRunHarvesting
dimattia Jun 21, 2017
7de94d0
first bunch of comments implemented
dimattia Jun 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 13 additions & 12 deletions CalibTracker/SiStripChannelGain/plugins/SiStripGainFromCalibTree.cc
View file
Open in desktop
Expand Up @@ -1360,18 +1360,19 @@ void SiStripGainFromCalibTree::qualityMonitor() {
if(SubDet>=3) NoMPV->Fill(z,R);

} else { // Fit of MPV
if(FitMPV>0.) Gains->Fill(Gain);

MPVs->Fill(FitMPV);
if(Thickness<0.04) MPVs320->Fill(Phi,FitMPV);
if(Thickness>0.04) MPVs500->Fill(Phi,FitMPV);

MPVError->Fill(FitMPVErr);
MPVErrorVsMPV->Fill(FitMPV,FitMPVErr);
MPVErrorVsEta->Fill(Eta,FitMPVErr);
MPVErrorVsPhi->Fill(Phi,FitMPVErr);
MPVErrorVsN->Fill(NEntries,FitMPVErr);

if ( SubDet>=3 ) { // remove input from Pixel detector id.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you not just skip SubDet <3 from the start of the loop? (eg, continue after line 1329?)

if(FitMPV>0.) Gains->Fill(Gain);

MPVs->Fill(FitMPV);
if(Thickness<0.04) MPVs320->Fill(Phi,FitMPV);
if(Thickness>0.04) MPVs500->Fill(Phi,FitMPV);

MPVError->Fill(FitMPVErr);
MPVErrorVsMPV->Fill(FitMPV,FitMPVErr);
MPVErrorVsEta->Fill(Eta,FitMPVErr);
MPVErrorVsPhi->Fill(Phi,FitMPVErr);
MPVErrorVsN->Fill(NEntries,FitMPVErr);
}
if(SubDet==3) {
MPV_Vs_EtaTIB->Fill(Eta,FitMPV);
MPV_Vs_PhiTIB->Fill(Phi,FitMPV);
Expand Down
2 changes: 1 addition & 1 deletion CalibTracker/SiStripChannelGain/python/SiStripGainsPCLHarvester_cfi.py
View file
Open in desktop
Expand Up @@ -9,6 +9,6 @@
calibrationMode = cms.untracked.string('StdBunch'),
minNrEntries = cms.untracked.double(25),
GoodFracForTagProd = cms.untracked.double(0.98),
NClustersForTagProd = cms.untracked.double(1E8),
NClustersForTagProd = cms.untracked.double(8E8),
ChargeHisto = cms.untracked.vstring('TIB','TIB_layer_1','TOB','TOB_layer_1','TIDminus','TIDplus','TECminus','TECplus')
)
2 changes: 1 addition & 1 deletion CalibTracker/SiStripChannelGain/python/computeGain_cff.py
View file
Open in desktop
Expand Up @@ -31,7 +31,7 @@
saveSummary = cms.untracked.bool(False),

GoodFracForTagProd = cms.untracked.double(0.98),
NClustersForTagProd = cms.untracked.double(1E8),
NClustersForTagProd = cms.untracked.double(8E8),


SinceAppendMode = cms.bool(True),
Expand Down
23 changes: 12 additions & 11 deletions CalibTracker/SiStripChannelGain/src/SiStripGainsPCLHarvester.cc
View file
Open in desktop
Expand Up @@ -265,18 +265,19 @@ SiStripGainsPCLHarvester::gainQualityMonitor(DQMStore::IBooker& ibooker_, const
if(SubDet>=3) NoMPV->Fill(z,R);

} else { // Fit of MPV
if(FitMPV>0.) Gains->Fill(Gain);
if ( SubDet>=3 ) { // remove input from Pixel detector id.
if(FitMPV>0.) Gains->Fill(Gain);

MPVs->Fill(FitMPV);
if(Thickness<0.04) MPVs320->Fill(Phi,FitMPV);
if(Thickness>0.04) MPVs500->Fill(Phi,FitMPV);

MPVError->Fill(FitMPVErr);
MPVErrorVsMPV->Fill(FitMPV,FitMPVErr);
MPVErrorVsEta->Fill(Eta,FitMPVErr);
MPVErrorVsPhi->Fill(Phi,FitMPVErr);
MPVErrorVsN->Fill(NEntries,FitMPVErr);

MPVs->Fill(FitMPV);
if(Thickness<0.04) MPVs320->Fill(Phi,FitMPV);
if(Thickness>0.04) MPVs500->Fill(Phi,FitMPV);

MPVError->Fill(FitMPVErr);
MPVErrorVsMPV->Fill(FitMPV,FitMPVErr);
MPVErrorVsEta->Fill(Eta,FitMPVErr);
MPVErrorVsPhi->Fill(Phi,FitMPVErr);
MPVErrorVsN->Fill(NEntries,FitMPVErr);
}
if(SubDet==3) {
MPV_Vs_EtaTIB->Fill(Eta,FitMPV);
MPV_Vs_PhiTIB->Fill(Phi,FitMPV);
Expand Down