Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTPPS: fixes for 2017 diamond data taking operations (backport to 9_2_X) #19434

Conversation

forthommel
Copy link
Contributor

Backport of #19185

This PR introduces a set of useful fixes for 2017 data-taking with CTPPS diamond detector, namely:

  • a bug fix in the rechits time-over-threshold computation (removed the extra time-slice subtraction)
  • lighter DQM source (reduced number of output histograms, coarser binnings)

Needed for data-taking (i.e. asap)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @forthommel (Laurent Forthomme) for CMSSW_9_2_X.

It involves the following packages:

DQM/CTPPS
RecoCTPPS/TotemRPLocal

@perrotta, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

It looks like #19185 was already automatically backported to 92X, see latest entries for 92X in http://cms-sw.github.io/showIB.html

If confirmed that this was not a mistake (@davidlange6?), then this PR can be closed.
By the way, reco is fine about having this PR backported to 92X, since it is meant to data taking

@slava77
Copy link
Contributor

slava77 commented Jun 27, 2017

@cmsbuild please test

@perrotta
I do not see anything equivalent to this PR merged to 92X

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20942/console Started: 2017/06/27 17:53

@perrotta
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19434/20942/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1752681
  • DQMHistoTests: Total failures: 14515
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1738000
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jun 27, 2017

+1

for #19434 84b1cfe

@forthommel
Copy link
Contributor Author

@dmitrijus, @davidlange6 ?

@slava77
Copy link
Contributor

slava77 commented Jul 5, 2017

@dmitrijus
please check this PR and comment or sign.
Thank you.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 01de002 into cms-sw:CMSSW_9_2_X Jul 6, 2017
@forthommel forthommel deleted the ctpps-diamond_dqm_and_unpacker-9_2_X-rebase_to_actual_9_2_X_because_in_the_meantime_they_decided_to_move_to_9_3_X branch July 17, 2017 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants