New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTPPS: fixes for 2017 diamond data taking operations (backport to 9_2_X) #19434
Conversation
Conflicts: DQM/CTPPS/python/ctppsDQM_cff.py DQM/CTPPS/test/diamond_dqm_test_cfg.py
A new Pull Request was created by @forthommel (Laurent Forthomme) for CMSSW_9_2_X. It involves the following packages: DQM/CTPPS @perrotta, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
It looks like #19185 was already automatically backported to 92X, see latest entries for 92X in http://cms-sw.github.io/showIB.html If confirmed that this was not a mistake (@davidlange6?), then this PR can be closed. |
The tests are being triggered in jenkins. |
@slava77 : it is not there any more, see https://hypernews.cern.ch/HyperNews/CMS/get/swDevelopment/3403/1/1/1/2/1/1.html |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
@dmitrijus |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
Backport of #19185
This PR introduces a set of useful fixes for 2017 data-taking with CTPPS diamond detector, namely:
Needed for data-taking (i.e. asap)