Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of HLT menu to V1.2 and adjustment of GTs for TSG tests (92X) (on top of #19431 and #19445) #19468

Merged
merged 14 commits into from Jul 11, 2017

Conversation

Martin-Grunewald
Copy link
Contributor

Adjustment of GTs for internal TSG tests (92X)
Based on 924
Includes #19431 and #19445

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_9_2_X.

It involves the following packages:

Configuration/AlCa
Configuration/HLT
HLTrigger/Configuration

@ghellwig, @cmsbuild, @silviodonato, @arunhep, @cerminar, @Martin-Grunewald, @franzoni, @fwyzard, @davidlange6, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @tocheng, @jalimena, @mmusich, @geoff-smith this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 29, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20975/console Started: 2017/06/29 09:01

@arunhep
Copy link
Contributor

arunhep commented Jun 29, 2017

@Martin-Grunewald I dont understand why autoCond is listed here in the change of files.
Can you may be rebase it so that you can get rid of AlCa signature?

@Martin-Grunewald
Copy link
Contributor Author

This is because #19431 (and #19445) are not yet integrated in 92X, and this is on top of those,
they they are included here. Once #19431 is in, I can rebase the other two PRs.

@Martin-Grunewald Martin-Grunewald deleted the autoAdjustment92X branch June 29, 2017 08:21
@cmsbuild
Copy link
Contributor

-1

Tested at: bcc18ff

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
88b4d4b
50ad124
fc51b5b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19468/20975/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19468/20975/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19468/20975/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --magField 38T_PostLS1 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Thu Jun 29 10:24:03 2017-date Thu Jun 29 10:16:35 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 29 10:24:03 2017-date Thu Jun 29 10:16:35 2017 s - exit: 16640
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PIon --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --magField 38T_PostLS1 --eventcontent RAW --fileout file:RelVal_Raw_PIon_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Thu Jun 29 10:26:33 2017-date Thu Jun 29 10:21:22 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 29 10:26:33 2017-date Thu Jun 29 10:21:22 2017 s - exit: 16640
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Thu Jun 29 10:33:41 2017-date Thu Jun 29 10:29:17 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Jun 29 10:33:41 2017-date Thu Jun 29 10:29:17 2017 s - exit: 16640

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
88b4d4b
50ad124
fc51b5b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19468/20975/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19468/20975/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor Author

hold

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2017

Pull request has been put on hold by @Martin-Grunewald
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Jul 2, 2017
@Martin-Grunewald
Copy link
Contributor Author

unhold

@cmsbuild cmsbuild removed the hold label Jul 3, 2017
@Martin-Grunewald
Copy link
Contributor Author

@arunhep @franzoni
Please sign - the AlCa part is the SAME as already signed in included #19431 and #19445.
Thanks!

@arunhep
Copy link
Contributor

arunhep commented Jul 3, 2017

+1

@Martin-Grunewald
Copy link
Contributor Author

@Dr15Jones
please sign this backport PR (as far as core is concerned: addOnTests)

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

@Martin-Grunewald - ha- i was fooled by the title of this PR, which is now rather misleading. Please update the title and close the obsoleted PRs. I'd rather we see a glimpse of L1 checks in 930pre1 before pushing this back - there were a lot of pieces to be assembled in the end (basically to get things running without crashing)

@Martin-Grunewald Martin-Grunewald changed the title Adjustment of GTs for internal TSG tests (92X) (on top of #19431 and #19445) Update of HLT menu to V1.2 and adjustment of GTs for TSG tests (92X) (on top of #19431 and #19445) Jul 6, 2017
@Martin-Grunewald
Copy link
Contributor Author

This works for L1 as in 93X - and you have already integrated #19511.
Title of this PR is updated and the other two (one asked to be) closed.

@Martin-Grunewald
Copy link
Contributor Author

@davidlange6
BTW, we can not wait for 930pre1 relval cycle - that takes too long, and anyway important parts were integrated in 93X only after 930pre1 (V1.2 menu and GT adjustment etc)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 20f1283 into cms-sw:CMSSW_9_2_X Jul 11, 2017
@Martin-Grunewald Martin-Grunewald deleted the autoAdjustment92X branch September 7, 2017 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants