New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not throw on non-matching triggers in ecalTrgHLT (92X) #19511
Conversation
A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_9_2_X. It involves the following packages: Calibration/EcalAlCaRecoProducers @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
backport of #19510 |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@@ -4,6 +4,7 @@ | |||
ecalTrgHLT = HLTrigger.HLTfilters.hltHighLevel_cfi.hltHighLevel.clone( | |||
# eventSetupPathsKey='AlCa_EcalPhiSym*', # this is the HLT path that can be used | |||
eventSetupPathsKey='EcalTrg', | |||
throw = cms.bool( False ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Martin-Grunewald
to get some context : what is motivation behind this change and what benefits do you get?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the discussion at the equivalent 93X PR #19510:
#19510 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks.
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
Do not throw on non-matching triggers in ecalTrgHLT (92X)