New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker alignment validation das client #19540
Tracker alignment validation das client #19540
Conversation
Compatibility to still work until the dasgoclient is updated in cmsdist. Once it's updated, removing the marked sections should result in no change in behavior.
A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_9_2_X. It involves the following packages: Alignment/OfflineValidation @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
Backport of #19539
Make the dataset class compatible with the new das go client.
Some sections are there temporarily to revert to the old das_client until the dasgoclient is updated in cvmfs. Once it's updated, those sections can be removed without any effect on the code.
The dasgoclient makes
validateAlignments.py -c testValidate.ini -N testValidate -n
a factor of 3 faster. I checked that we get equivalent behavior with either the new or the old clients.https://hypernews.cern.ch/HyperNews/CMS/get/sw-develtools/2504.html