Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker alignment validation das client #19540

Merged
merged 3 commits into from Jul 6, 2017

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Jul 4, 2017

Backport of #19539

Make the dataset class compatible with the new das go client.

Some sections are there temporarily to revert to the old das_client until the dasgoclient is updated in cvmfs. Once it's updated, those sections can be removed without any effect on the code.

The dasgoclient makes validateAlignments.py -c testValidate.ini -N testValidate -n a factor of 3 faster. I checked that we get equivalent behavior with either the new or the old clients.

https://hypernews.cern.ch/HyperNews/CMS/get/sw-develtools/2504.html

Compatibility to still work until the dasgoclient is
updated in cmsdist.  Once it's updated, removing the
marked sections should result in no change in behavior.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_9_2_X.

It involves the following packages:

Alignment/OfflineValidation

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor

arunhep commented Jul 4, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21131/console Started: 2017/07/04 15:26

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19540/21131/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1813730
  • DQMHistoTests: Total failures: 29333
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1784231
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Jul 5, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fb5a0fb into cms-sw:CMSSW_9_2_X Jul 6, 2017
@hroskes hroskes deleted the tkalvalidation-dasgoclient branch July 7, 2017 16:09
@hroskes hroskes restored the tkalvalidation-dasgoclient branch July 11, 2017 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants