Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove temporary sections #19692

Merged
merged 1 commit into from Jul 25, 2017

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Jul 11, 2017

backport of #19691

These sections were added in #19540 so that the scripts would work until the dasgoclient was updated. Now that it is, they can be removed with no effect on the behavior of the code.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 11, 2017

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_9_2_X.

It involves the following packages:

Alignment/OfflineValidation

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor

arunhep commented Jul 12, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21414/console Started: 2017/07/12 21:57

@cmsbuild
Copy link
Contributor

-1

Tested at: 739ae89

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4661813
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19692/21414/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19692/21414/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19692/21414/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests AddOn

  • Unit Tests:

I found errors in the following unit tests:

---> test testAlignmentOfflineValidation had ERRORS

  • AddOn:

I found errors in the following addon tests:

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4661813
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19692/21414/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19692/21414/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19692/21414/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1756608
  • DQMHistoTests: Total failures: 29853
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1726589
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@mmusich
Copy link
Contributor

mmusich commented Jul 13, 2017

hi @hroskes and @arunhep, I am afraid that the failing test is due again to broken unit test in the IB. PR #19615 should be integrated first to get a clean IB to test this PR with.

@davidlange6
Copy link
Contributor

+1

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit a815f88 into cms-sw:CMSSW_9_2_X Jul 25, 2017
@hroskes hroskes deleted the tkalvalidation-dasgoclient branch July 25, 2017 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants