Enhance DQM for Pixel cluster on tracks

[VinInn]

removed clusters off track, cleaned and streamlined code
added
plots by outer/inner Ladders (by hand, waiting the histograms manager is enhanced)
added cluster shape monitoring
as fraction of cluster passing the shape filter
and comparison of size prediction and actual

We shall plan back port to start running in production ASAP

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for master.

It involves the following packages:

DQM/SiPixelPhase1TrackClusters

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[VinInn]

@cmsbuild, please test

[VinInn]

@arizzi @gpetruc @rovere @makortel @boudoul @veszpv @venturia FYI

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21264/console Started: 2017/07/07 19:53

[cmsbuild]

+1
Tested at: 575003d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19618/21264/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
7c04e1c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19618/21264/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19618/21264/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19618/21264/summary.html

Comparison Summary:

• You potentially added 469 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1790667
• DQMHistoTests: Total failures: 14961
• DQMHistoTests: Total nulls: 156
• DQMHistoTests: Total successes: 1775384
• DQMHistoTests: Total skipped: 166
• DQMHistoTests: Total Missing objects: 0
• Checked 93 log files, 14 edm output root files, 23 DQM output files

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1

[Dr15Jones]

This pull requests appears to be causing two of the IB RelVal workflows to fail: 7.2 and 7.3:
https://cms-sw.github.io/relvalLogDetail.html#slc7_aarch64_gcc530;CMSSW_9_3_X_2017-07-11-1100

[davidlange6]

ping @VinInn

[VinInn]

add siPixelClusterShapeCache to cosmic wf?
Most probably easier to add isValid to the handle (I suppose is enough) and protect the histo filling...
before tomorrow at noon (can be done even on the web...)