Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml files containing updated summary plot limit + fix for cosmic [Backport combining #19447 and #19713] #19821

Merged
merged 1 commit into from Jul 20, 2017

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Jul 19, 2017

Greetings
xml files for the qTests for the DQM PixelPhase1 summary plots and fix for cosmic sequence

this is the backport of #19447 and #19713

I combined the two since #19713 is fixing #19447 - Those are already merged in 93X (and even part of 930_pre2)
@ckmackay FYI

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for CMSSW_9_2_X.

It involves the following packages:

DQM/SiPixelPhase1Config
RecoTracker/Configuration

@perrotta, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @hdelanno, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @fioriNTU, @gpetruc, @idebruyn, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@ckmackay
Copy link
Contributor

ckmackay commented Jul 19, 2017 via email

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21616/console Started: 2017/07/19 20:22

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19821/21616/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1756428
  • DQMHistoTests: Total failures: 15042
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1741220
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jul 20, 2017

+1

for #19821 13ebe3b

  • reco changes are only in RecoTracker/Configuration/python/RecoTrackerP5_cff.py , where a module siPixelClusterShapeCache is added to tracksP5. This is a pre-emptive bugfix to 92X PR backport of 19618 #19629 (backport of Enhance DQM for Pixel cluster on tracks #19618 which introduced problems in cosmics workflows)
  • jenkins tests pass
    • there are no changes in RECO [as expected]
    • there are some changes in "PixelPhase1/Run summary/Summary" and a related summary plot in /EventInfo folder

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6e7b40c into cms-sw:CMSSW_9_2_X Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants