Update pythia8 pt hat reweight user hook #19668

aperloff · 2017-07-10T20:27:02Z

This PR would provide a new UserHook to Pythia in order to generate a sample with a truly "flat" pThat spectrum. These types of samples are currently used by the JetMET group for jet energy calibrations, but currently we are using a sub-optimal configuration; the new method works much better. It is not foreseen that this PR will have any effect on other packages. This should simply add a new feature to the CMSSW-Pythia8 interface.

We would like to include this feature in CMSSW in time for the upcoming 2017 MC production campaign using CMSSW_9_3_0.

…. The new scheme is empirically derived and relies on the pythia8 user hooks.

… be removed.

cmsbuild · 2017-07-10T20:27:20Z

A new Pull Request was created by @aperloff (Alexx Perloff) for master.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@efeyazgan, @perrozzi, @thuer, @cmsbuild, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

perrozzi · 2017-07-10T20:58:03Z

please test

cmsbuild · 2017-07-10T20:58:21Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21340/console Started: 2017/07/10 23:03

cmsbuild · 2017-07-10T22:10:31Z

-1

Tested at: 0a7b0c1

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0619998
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19668/21340/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19668/21340/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19668/21340/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Mon Jul 10 23:37:44 2017-date Mon Jul 10 23:36:07 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02480/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_3_X_2017-07-10-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Jul 10 23:37:44 2017-date Mon Jul 10 23:36:07 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Mon Jul 10 23:37:44 2017-date Mon Jul 10 23:36:07 2017 s - exit: 21248
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns --magField 38T_PostLS1 : FAILED - time: date Mon Jul 10 23:37:06 2017-date Mon Jul 10 23:36:11 2017 s - exit: 21248
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Mon Jul 10 23:37:27 2017-date Mon Jul 10 23:36:16 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02480/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_3_X_2017-07-10-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Jul 10 23:37:27 2017-date Mon Jul 10 23:36:16 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Mon Jul 10 23:37:27 2017-date Mon Jul 10 23:36:16 2017 s - exit: 21248
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Mon Jul 10 23:37:39 2017-date Mon Jul 10 23:36:19 2017 s - exit: 21248
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun2016 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun2016_MC.root : FAILED - time: date Mon Jul 10 23:38:17 2017-date Mon Jul 10 23:36:23 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02480/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_3_X_2017-07-10-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun2016.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Jul 10 23:38:17 2017-date Mon Jul 10 23:36:23 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun2016,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun2016 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun2016_MC.root --fileout file:RelVal_Raw_GRun2016_MC_HLT_RECO.root : FAILED - time: date Mon Jul 10 23:38:17 2017-date Mon Jul 10 23:36:23 2017 s - exit: 21248
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Mon Jul 10 23:37:39 2017-date Mon Jul 10 23:36:32 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02480/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_3_X_2017-07-10-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Jul 10 23:37:39 2017-date Mon Jul 10 23:36:32 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Mon Jul 10 23:37:39 2017-date Mon Jul 10 23:36:32 2017 s - exit: 21248
cmsDriver.py TTbar_Tauola_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Mon Jul 10 23:38:10 2017-date Mon Jul 10 23:36:53 2017 s - exit: 21248
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02480/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_3_X_2017-07-10-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Jul 10 23:38:10 2017-date Mon Jul 10 23:36:53 2017 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Mon Jul 10 23:38:10 2017-date Mon Jul 10 23:36:53 2017 s - exit: 21248

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0619998
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19668/21340/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19668/21340/git-merge-result

cmsbuild · 2017-07-10T22:10:34Z

Comparison job queued.

aperloff · 2017-07-10T22:35:40Z

I have a couple of questions after the failed tests:

Why was an additional PR (0619998) added on top of the merge for this PR? I just don't know what this has to do with the current PR.
The AddOn test that failed seem to be looking for the file MagneticField/GeomBuilder/data/MagneticFieldVolumes_1_v7_large.xml, which isn't in the search path. I didn't touch that file with this PR, so is it missing in the IB? Is it something I did wrong?

aperloff · 2017-07-10T22:48:08Z

Tagging some people involved in this PR who might be interested in its progress
@karavdin, @kirschen, @miquork

cmsbuild · 2017-07-10T23:31:07Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19668/21340/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1884334
DQMHistoTests: Total failures: 114
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1884054
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

aperloff · 2017-07-12T14:55:56Z

Have the AddOn tests been updated or has the IB been fixed? Can the tests for this PR be retried or will they just fail again?

kpedro88 · 2017-07-12T17:51:34Z

please test

cmsbuild · 2017-07-12T17:51:52Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21409/console Started: 2017/07/12 19:53

cmsbuild · 2017-07-15T03:37:18Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19668/21501/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 2022761
DQMHistoTests: Total failures: 14516
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2008079
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

aperloff · 2017-07-19T21:32:56Z

@perrozzi If this PR meets with your approval would you please sign off on it before this week's ORP meeting? I just want to make sure the PR can be approved in time for CMSSW_9_3_0.

perrozzi · 2017-07-19T22:42:51Z

+1

cmsbuild · 2017-07-19T22:43:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-07-20T07:39:27Z

+1

Dr15Jones · 2017-07-20T17:12:23Z

This pull request is causing failures in the IB RelVals:

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc630/CMSSW_9_3_X_2017-07-20-1100/pyRelValMatrixLogs/run/5.6_QCD_FlatPt_15_3000+QCDFlatPt153000FS+HARVESTFS/step1_QCD_FlatPt_15_3000+QCDFlatPt153000FS+HARVESTFS.log

aperloff · 2017-07-20T17:19:17Z

@Dr15Jones This PR added two parameters to an existing function (https://github.com/cms-sw/cmssw/pull/19668/files#diff-96dae42223a6b851894a2bd75bc7314dR219). Were there IB RelVal tests that used the PtHatReweightUserHook class (https://github.com/cms-sw/cmssw/pull/19668/files#diff-96dae42223a6b851894a2bd75bc7314dL213)? Why did they not show up when doing runTheMatrix?

Dr15Jones · 2017-07-20T17:24:43Z

The pull request tests only run a very small number of potential workflows from runTheMatrix, and apparently the flat distribution workflow is not used. The IB runs all the workflows.

aperloff · 2017-07-20T17:30:15Z

@Dr15Jones Can the test be updated or can I do another PR to make the parameter optional? If the latter, how would I go about doing that in a way that is acceptable to the developers of CMSSW? I was thinking I could use something like:
if(params.exists( "pTRef" ) && params.exists( "power" ))
constructor with parameters
else
constructor without parameters

Dr15Jones · 2017-07-20T17:33:36Z

You'd need to create a new pull request. The use of ParameterSet::exists is being deprecated in CMSSW since the use of fillDescriptions is preferred.

Rather than adding more exists (which is ultimately up to the generator L2 to decide) I would suggest adding in the newly needed parameters into the configuration files used by the workflows.

aperloff · 2017-07-20T17:39:59Z

Where are the configuration files used by the workflows stored? I've never edited a runTheMatrix workflow. I'd be happy to do the change there as that would be the easiest path.

Dr15Jones · 2017-07-20T17:51:08Z

I'd suggest doing a github search on the parameter used to turn on the flat distribution. I would expect that to find the files that need to be updated.

Dr15Jones · 2017-07-20T18:11:54Z

It looks like they are kept in Configuration/Generator/python.

Dr15Jones · 2017-07-20T18:14:51Z

Doing a git grep reweightGen gave the following hits in python

Configuration/Generator/python/InclusiveppMuX_8TeV_TuneCUETP8M1_cfi.py:                         reweightGen = cms.PSet(),
Configuration/Generator/python/QCDForPF_13TeV_TuneCUETP8M1_cfi.py:                         reweightGen = cms.PSet(),
Configuration/Generator/python/QCDForPF_14TeV_TuneCUETP8M1_cfi.py:                         reweightGen = cms.PSet(),
Configuration/Generator/python/QCDForPF_8TeV_TuneCUETP8M1_cfi.py:                         reweightGen = cms.PSet(), 
Configuration/Generator/python/QCD_Pt-15To7000_TuneCUETP8M1_Flat_14TeV-pythia8_cff.py:        #reweightGen = cms.bool(True), #
GeneratorInterface/Pythia8Interface/test/pythia8ex2_cfg.py:    #reweightGen = cms.PSet(),
GeneratorInterface/Pythia8Interface/test/pythia8ex2_cfg.py:    #reweightGenRap = cms.PSet( # flat in eta
GeneratorInterface/Pythia8Interface/test/pythia8ex2_cfg.py:    #reweightGenPtHatRap = cms.PSet( # flat in Pt and eta

aperloff · 2017-07-20T18:15:43Z

I'm working on a new PR right now.

aperloff · 2017-07-20T18:36:43Z

A new PR #19843 has been made which should fix this problem.

alberto-sanchez · 2017-08-15T12:18:24Z

@aperloff, can you please do the PR for backporting this to 92x and eventually 71x?

Alexx Perloff added 3 commits July 10, 2017 15:04

Added new reweighting scheme to flatten the QCD generation ased on pT…

6bc4481

…. The new scheme is empirically derived and relies on the pythia8 user hooks.

New piecewise weighting function. Still has comments that may need to…

0a8b82c

… be removed.

Remove some comments and unused code before doing the PR.

0a7b0c1

cmsbuild added this to the CMSSW_9_3_X milestone Jul 10, 2017

cmsbuild added comparison-pending generators-pending orp-pending pending-signatures tests-pending labels Jul 10, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 10, 2017

cmsbuild added tests-rejected and removed tests-started labels Jul 10, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 10, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-rejected labels Jul 12, 2017

cmsbuild added the tests-approved label Jul 14, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 15, 2017

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Jul 19, 2017

cmsbuild added orp-approved and removed orp-pending labels Jul 20, 2017

cmsbuild merged commit df9625c into cms-sw:master Jul 20, 2017

aperloff mentioned this pull request Jul 20, 2017

Update Pythia8 Flat Configuration Files #19843

Merged

perrozzi mentioned this pull request Jul 21, 2017

Cleanup Configuration/Generator/python #19772

Merged

aperloff mentioned this pull request Jan 24, 2019

LWTNN Deep Neural Networks for track classification #21717

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update pythia8 pt hat reweight user hook #19668

Update pythia8 pt hat reweight user hook #19668

aperloff commented Jul 10, 2017

cmsbuild commented Jul 10, 2017

perrozzi commented Jul 10, 2017

cmsbuild commented Jul 10, 2017 •

edited

cmsbuild commented Jul 10, 2017

cmsbuild commented Jul 10, 2017

aperloff commented Jul 10, 2017

aperloff commented Jul 10, 2017

cmsbuild commented Jul 10, 2017

aperloff commented Jul 12, 2017

kpedro88 commented Jul 12, 2017

cmsbuild commented Jul 12, 2017 •

edited

cmsbuild commented Jul 15, 2017

aperloff commented Jul 19, 2017

perrozzi commented Jul 19, 2017

cmsbuild commented Jul 19, 2017

davidlange6 commented Jul 20, 2017

Dr15Jones commented Jul 20, 2017

aperloff commented Jul 20, 2017

Dr15Jones commented Jul 20, 2017

aperloff commented Jul 20, 2017

Dr15Jones commented Jul 20, 2017

aperloff commented Jul 20, 2017

Dr15Jones commented Jul 20, 2017

Dr15Jones commented Jul 20, 2017

Dr15Jones commented Jul 20, 2017

aperloff commented Jul 20, 2017

aperloff commented Jul 20, 2017

alberto-sanchez commented Aug 15, 2017

Update pythia8 pt hat reweight user hook #19668

Update pythia8 pt hat reweight user hook #19668

Conversation

aperloff commented Jul 10, 2017

cmsbuild commented Jul 10, 2017

perrozzi commented Jul 10, 2017

cmsbuild commented Jul 10, 2017 • edited

cmsbuild commented Jul 10, 2017

cmsbuild commented Jul 10, 2017

aperloff commented Jul 10, 2017

aperloff commented Jul 10, 2017

cmsbuild commented Jul 10, 2017

aperloff commented Jul 12, 2017

kpedro88 commented Jul 12, 2017

cmsbuild commented Jul 12, 2017 • edited

cmsbuild commented Jul 15, 2017

aperloff commented Jul 19, 2017

perrozzi commented Jul 19, 2017

cmsbuild commented Jul 19, 2017

davidlange6 commented Jul 20, 2017

Dr15Jones commented Jul 20, 2017

aperloff commented Jul 20, 2017

Dr15Jones commented Jul 20, 2017

aperloff commented Jul 20, 2017

Dr15Jones commented Jul 20, 2017

aperloff commented Jul 20, 2017

Dr15Jones commented Jul 20, 2017

Dr15Jones commented Jul 20, 2017

Dr15Jones commented Jul 20, 2017

aperloff commented Jul 20, 2017

aperloff commented Jul 20, 2017

alberto-sanchez commented Aug 15, 2017

cmsbuild commented Jul 10, 2017 •

edited

cmsbuild commented Jul 12, 2017 •

edited