Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pythia8 Flat Configuration Files #19843

Merged
merged 1 commit into from Jul 21, 2017

Conversation

aperloff
Copy link
Contributor

Update the Pythia8 configuration files which flatten the pThat distribution. This would bring the configuration files in line with #19668 and fix a problem with some runTheMatrix tests.

…bution. This would bring the configuration files in line with a previous PR.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aperloff (Alexx Perloff) for master.

It involves the following packages:

Configuration/Generator
GeneratorInterface/Pythia8Interface

@efeyazgan, @perrozzi, @thuer, @cmsbuild, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@ghellwig, @alberto-sanchez, @agrohsje, @mkirsano, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@aperloff
Copy link
Contributor Author

Is there any way we can have cmsbuild check the RelVal tests which were failing before?

@Dr15Jones
Copy link
Contributor

please test workflow 5.6

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 20, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21643/console Started: 2017/07/20 20:41

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Dr15Jones
Copy link
Contributor

The workflow 5.6 did succeeded.

@perrozzi
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19843/21643/summary.html

Comparison Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2346597
  • DQMHistoTests: Total failures: 15152
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2331279
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants