Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix saveTags() and abs() use in HLTEgammaL1TMatchFilterRegional (93X) #19750

Merged
merged 1 commit into from Jul 17, 2017
Merged

Fix saveTags() and abs() use in HLTEgammaL1TMatchFilterRegional (93X) #19750

merged 1 commit into from Jul 17, 2017

Conversation

Martin-Grunewald
Copy link
Contributor

Fix saveTags() and abs() use in HLTEgammaL1TMatchFilterRegional (93X)

@cmsbuild cmsbuild added this to the CMSSW_9_3_X milestone Jul 14, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master.

It involves the following packages:

HLTrigger/Egamma

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald Martin-Grunewald mentioned this pull request Jul 14, 2017
Merged
@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 14, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21492/console Started: 2017/07/14 20:56

@cmsbuild
Copy link
Contributor

+1
Tested at: 08ab8a4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19750/21492/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a077a53
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19750/21492/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19750/21492/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19750/21492/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2022761
  • DQMHistoTests: Total failures: 15032
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2007563
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7b1c63d into cms-sw:master Jul 17, 2017
@Martin-Grunewald
Copy link
Contributor Author

type bugfix

@Sam-Harper
Copy link
Contributor

Many thanks Martin for this!

@Martin-Grunewald Martin-Grunewald deleted the FixOfHLTEgammaL1TMatchFilterRegional branch August 31, 2017 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix comparison-available fully-signed hlt-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_3_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Martin-Grunewald @cmsbuild @davidlange6 @Sam-Harper