Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel cluster shape: new calibration for Phase1 and Phase2 #19824

Merged
merged 28 commits into from Jul 28, 2017

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Jul 19, 2017

This PR is composed of several components

  1. A new version of the PixelClusterShapeExtractor that tries to deal with spit/merged clusters at best
  2. A modified version of the ClusterShapeHitFilter that makes provision to use a different file for the first layer of the Barrel as it is the only one affected by long clusters and in 2017 data affected by inefficiency
  3. A new version of the calibration files for Phase1 and Phase2
  4. a rearrangement of DQM to monitor the ClusterShape
  5. a python notebook to analyze and compare calibration files
  6. new configuration files to perform the "extraction"
  7. updated documentation

The main reason of a new calibration is the changes in geometry (in particular for the forward pixel)
that happened in 910_pre3.
The new calibrations are based on 90K MinBias events from recent RelVal

MVA
for phase1
http://innocent.home.cern.ch/innocent/RelVal/pu35_candpcsf/
for phase2
http://innocent.home.cern.ch/innocent/RelVal/newPCSF2/

for phase1 there is also a comparison of using

  1. the calibration obtained considering all layers
  2. the calibration obtained considering all layers but BPIX1
  3. and using the file " obtained considering all layers but BPIX1" for all layers but BPIX1 (for BPIX1 the file obtained considering all layers is used)
    http://innocent.home.cern.ch/innocent/RelVal/pu35_newpcsf/plots_highPurity/effandfake1.pdf

for Phase2 there is no difference.
for Phase1 there is no obvious improvements but more seeds in the forward region
(this is observable also in DQM for both data and mc) i.e. higher efficiency for quadruplets at eta~2
there is also an increase in fake rate in the barrel (the effect on late iterations are more difficult to establish as they are affected by the changes in the previous one)
Still this is the best calibration we can produce and the previous one was wrong as not covering properly the phasespace in the forward region (this calibration is the solution of an inverse problem, so it depends on the sample on which is trained)

It shall be noted that MVA (in particular for low-pt) is under retraining and shall be retrained once this PR is merged.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @VinInn (Vincenzo Innocente) for master.

It involves the following packages:

DQM/SiPixelPhase1TrackClusters
RecoPixelVertexing/PixelLowPtUtilities
RecoTracker/IterativeTracking

@perrotta, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @hdelanno, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @fioriNTU, @gpetruc, @idebruyn, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@VinInn
Copy link
Contributor Author

VinInn commented Jul 19, 2017

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21619/console Started: 2017/07/19 20:37

@slava77
Copy link
Contributor

slava77 commented Jul 19, 2017 via email

@VinInn
Copy link
Contributor Author

VinInn commented Jul 19, 2017

@slava77 look at http://innocent.home.cern.ch/innocent/RelVal/pu35_candpcsf/
the current one is blue and proposed is red
in any case in http://innocent.home.cern.ch/innocent/RelVal/pu35_newpcsf the current one is
blue and proposed is red as well

@VinInn
Copy link
Contributor Author

VinInn commented Jul 19, 2017

everything is with IBs of the last 10 days relval is pre2

@cmsbuild
Copy link
Contributor

-1

Tested at: 5cb6086

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
37b78ee
b5ed5c7
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19824/21619/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19824/21619/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19824/21619/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
10042.0 step2

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step2
runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

10024.0 step2
runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

  • AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Jul 19 21:38:47 2017-date Wed Jul 19 21:37:33 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Wed Jul 19 21:38:47 2017-date Wed Jul 19 21:37:33 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Jul 19 21:38:59 2017-date Wed Jul 19 21:37:34 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Wed Jul 19 21:38:59 2017-date Wed Jul 19 21:37:34 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Jul 19 21:47:38 2017-date Wed Jul 19 21:37:37 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Wed Jul 19 21:47:38 2017-date Wed Jul 19 21:37:37 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Jul 19 21:47:23 2017-date Wed Jul 19 21:37:47 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Wed Jul 19 21:47:23 2017-date Wed Jul 19 21:37:47 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun2016.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Jul 19 21:47:42 2017-date Wed Jul 19 21:37:54 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun2016,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun2016 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_GRun2016_MC.root --fileout file:RelVal_Raw_GRun2016_MC_HLT_RECO.root : FAILED - time: date Wed Jul 19 21:47:42 2017-date Wed Jul 19 21:37:54 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Jul 19 21:39:13 2017-date Wed Jul 19 21:37:56 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Wed Jul 19 21:39:13 2017-date Wed Jul 19 21:37:56 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Jul 19 21:47:02 2017-date Wed Jul 19 21:37:59 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Wed Jul 19 21:47:02 2017-date Wed Jul 19 21:37:59 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Jul 19 21:41:20 2017-date Wed Jul 19 21:38:16 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Wed Jul 19 21:41:20 2017-date Wed Jul 19 21:38:16 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Jul 19 21:47:15 2017-date Wed Jul 19 21:38:25 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Wed Jul 19 21:47:15 2017-date Wed Jul 19 21:38:25 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-19-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun2016.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Jul 19 21:41:51 2017-date Wed Jul 19 21:38:30 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun2016,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun2016 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_GRun2016_DATA.root --fileout file:RelVal_Raw_GRun2016_DATA_HLT_RECO.root : FAILED - time: date Wed Jul 19 21:41:51 2017-date Wed Jul 19 21:38:30 2017 s - exit: 18688

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
37b78ee
b5ed5c7
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19824/21619/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19824/21619/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@slava77
Copy link
Contributor

slava77 commented Jul 19, 2017

10024 step2:
MissingParameter: Parameter 'PixelShapeFileL1' not found.
seems related

@VinInn
Copy link
Contributor Author

VinInn commented Jul 20, 2017

HLT? I run the matrix.... will have a look

@VinInn
Copy link
Contributor Author

VinInn commented Jul 20, 2017

could somebody remind me which file need to be edited to fix HLT config?

@perrotta
Copy link
Contributor

perrotta commented Jul 20, 2017 via email

@VinInn
Copy link
Contributor Author

VinInn commented Jul 20, 2017

ok, how one deals with eras?

@perrotta
Copy link
Contributor

I would do it there... but probably @Martin-Grunewald can suggest you which is the best and most up to date procedure for it.

@VinInn
Copy link
Contributor Author

VinInn commented Jul 20, 2017

I see at the end of the file something done for pixel calib...

if (menuType == "GRun2016"):

will add in there

@cmsbuild
Copy link
Contributor

Comparison job queued.

@slava77
Copy link
Contributor

slava77 commented Jul 26, 2017 via email

@VinInn
Copy link
Contributor Author

VinInn commented Jul 26, 2017

did not change phase-0. Just a side comment...

@kpedro88
Copy link
Contributor

assign upgrade

@cmsbuild
Copy link
Contributor

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19824/21775/summary.html

Comparison Summary:

  • You potentially added 50 lines to the logs
  • Reco comparison results: 1386 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2360244
  • DQMHistoTests: Total failures: 20885
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2339192
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jul 26, 2017

+1

for #19824 2004b4b

  • changed pixel cluster shape parameter file for filtering (split to two files for phase-1); in line with the description. The MTV plots provided for phase-1 show some improvements in the initialStep (higher eff in the forward at almost constant fake rate); general track efficiency is almost unchanged while the fake rate is up by up to about 10% around |eta| of 1.
  • jenkins tests pass and comparisons with baseline show small differences in phase-{1,2} workflows
  • local tests roughly confirm the expected behavior with mostly small changes
    • changes in phase-2 are somewhat negligible
    • changes in phase-1 are in line with the MTV plots provided with the PR description (almost unchanged eff, a bit higher fakerate)
  • looking at data JetHT 299042 LS41 processed with the promptlike GT (and a snapshot override) in 930pre2, there are some apparent improvements, more significant than what's seen in MC
    • 2% more generalTracks; mostly in the initialStep
    • some increase in globalMuonTracks

all_sign943vsorig_jetht299042c_recotracks_generaltracks__rereco_obj_algo

small increase in bpix1 efficiency
wfjetht299042_hitpatt_eff_global

KShort mass points to an increase in efficiency as well (increase is mostly in the peak; about a 2/3 of the increment has vertex rho below 2 cm still in the pixel acceptance)
all_sign943vsorig_jetht299042c_recovertexcompositecandidates_generalv0candidates_kshort_rereco_obj_mass

@kpedro88
Copy link
Contributor

+1

@slava77
Copy link
Contributor

slava77 commented Jul 27, 2017

@vazzolini, @kmaeshima, @dmitrijus, @vanbesien, @Martin-Grunewald
DQM and HLT signatures are still missing for this PR.
Please check and propose changes or signoff. This is important for pre3.
Thank you.

@Martin-Grunewald
Copy link
Contributor

+1

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit ee43b2f into cms-sw:master Jul 28, 2017
@Dr15Jones
Copy link
Contributor

I believe this pull request has broken 40+ RelVal workflows in last nights IB. E.g.
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc630/CMSSW_9_3_X_2017-07-28-1100/pyRelValMatrixLogs/run/136.781_RunDoubleEG2017B+RunDoubleEG2017B+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017/step2_RunDoubleEG2017B+RunDoubleEG2017B+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017.log

With

----- Begin Fatal Exception 28-Jul-2017 13:40:08 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Processing  Event run: 297227 lumi: 33 event: 20650756 stream: 2
   [1] Running path 'HLT_MediumChargedIsoPFTau180HighPtRelaxedIso_Trk50_eta2p1_v5'
   [2] Calling method for module CAHitQuadrupletEDProducer/'hltPixelTracksHitQuadruplets'
   [3] Using EventSetup component ClusterShapeHitFilterESProducer/'' to make data ClusterShapeHitFilter/'ClusterShapeHitFilter' in record CkfComponentsRecord
Exception Message:
edm::FileInPath unable to find file RecoPixelVertexing/PixelLowPtUtilities/data/pixelShape_Phase1TkNewFPix.par anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbld/jenkins-workarea/workspace/ib-run-relvals/CMSSW_9_3_X_2017-07-28-1100/src:/build/cmsbld/jenkins-workarea/workspace/ib-run-relvals/CMSSW_9_3_X_2017-07-28-1100/external/slc7_amd64_gcc630/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-28-1100/external/slc7_amd64_gcc630/data
Current directory is: /build/cmsbld/jenkins-workarea/workspace/ib-run-relvals/CMSSW_9_3_X_2017-07-28-1100/pyRelval/136.781_RunDoubleEG2017B+RunDoubleEG2017B+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017
----- End Fatal Exception -------------------------------------------------

@VinInn
Copy link
Contributor Author

VinInn commented Jul 28, 2017

make sense: still how it passed validation?

@VinInn
Copy link
Contributor Author

VinInn commented Jul 28, 2017

no poison data!

@VinInn
Copy link
Contributor Author

VinInn commented Jul 28, 2017

#19824 fixit

@Dr15Jones
Copy link
Contributor

thanks!

davidlange6 added a commit that referenced this pull request Jul 28, 2017
fix HLT customize for "Pixel cluster shape: new calibration for Phase1 and Phase2" #19824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants