Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[93X] put back the scalers information in SiStrip ALCARECO gone missing in AfterAbortGap -> AAG #19858

Merged
merged 1 commit into from Jul 24, 2017

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 21, 2017

Greetings,
the intent of PR is re-add the scalers information already introduced once in #17981 (in CMSSW_9_1_X and backported in 8_0_X via #18062) in the ALCARECOSiStripCalMinBiasAfterAbortGap, that unfortunately has gone lost in #18753, during the AfterAbortGap -> AAG transition.
As a reminder the increase in event size is of ~135b/evt.
I profit of this PR to add the same info also in the producer for HI data-taking.
Since making this information available at ALCARECO level is rather useful to tune the event thresholds for the calibration in multi-run harvesting mode, I'd appreciate fast integration.

@mmusich
Copy link
Contributor Author

mmusich commented Jul 21, 2017

urgent

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Calibration/TkAlCaRecoProducers

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @threus, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 21, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21666/console Started: 2017/07/21 16:44

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19858/21666/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 2347494
  • DQMHistoTests: Total failures: 15007
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2332321
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 93 log files, 14 edm output root files, 23 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Jul 24, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a1f0a3b into cms-sw:master Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants