New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[93X] put back the scalers information in SiStrip ALCARECO gone missing in AfterAbortGap -> AAG #19858
Conversation
urgent |
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Calibration/TkAlCaRecoProducers @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
Greetings,
the intent of PR is re-add the scalers information already introduced once in #17981 (in CMSSW_9_1_X and backported in 8_0_X via #18062) in the
ALCARECOSiStripCalMinBiasAfterAbortGap
, that unfortunately has gone lost in #18753, during the AfterAbortGap -> AAG transition.As a reminder the increase in event size is of ~135b/evt.
I profit of this PR to add the same info also in the producer for HI data-taking.
Since making this information available at ALCARECO level is rather useful to tune the event thresholds for the calibration in multi-run harvesting mode, I'd appreciate fast integration.