HLT DQM for 9.3.x - clean up #19917
HLT DQM for 9.3.x - clean up #19917
Conversation
…QM92X Conflicts: DQMOffline/Trigger/python/ExoticaMonitoring_Client_cff.py DQMOffline/Trigger/python/ExoticaMonitoring_cff.py
…nt with HLT configuration)
…placedJetEffFromHitPatternHLT in DQMOffline_SecondStep_cff.py
Actually, this cherry-picks the relevant commits rather than doing a full merge.
Enabled checks:
boost-use-to-string
cppcoreguidelines-no-malloc
google-build-explicit-make-pair
misc-inefficient-algorithm
misc-string-compare
modernize-avoid-bind
modernize-deprecated-headers
modernize-loop-convert
modernize-make-shared
modernize-make-unique
modernize-pass-by-value
modernize-redundant-void-arg
modernize-replace-auto-ptr
modernize-shrink-to-fit
modernize-use-auto
modernize-use-bool-literals
modernize-use-emplace
modernize-use-equals-default
modernize-use-equals-delete
modernize-use-nullptr
modernize-use-override
modernize-use-transparent-functors
modernize-use-using
performance-faster-string-find
performance-for-range-copy
performance-implicit-cast-in-loop
performance-inefficient-string-concatenation
performance-type-promotion-in-math-fn
performance-unnecessary-copy-initialization
performance-unnecessary-value-paramnnSee http://releases.llvm.org/4.0.0/tools/clang/tools/extra/docs/clang-tidy/index.html for details.
fwyzard
force-pushed
the
HLT_DQM_for_93x_cleanup
branch
from
e7f90c9
to
6fb1e35
Compare
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #19917 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again. |
|
Updated following #19916, and cherry-picking the final cleanup. |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
merge |
Follow up to #19916.
Cleaned up by clang-tidy 4.0.0 modernize checks
Enabled checks:
boost-use-to-string
cppcoreguidelines-no-malloc
google-build-explicit-make-pair
misc-inefficient-algorithm
misc-string-compare
modernize-avoid-bind
modernize-deprecated-headers
modernize-loop-convert
modernize-make-shared
modernize-make-unique
modernize-pass-by-value
modernize-redundant-void-arg
modernize-replace-auto-ptr
modernize-shrink-to-fit
modernize-use-auto
modernize-use-bool-literals
modernize-use-emplace
modernize-use-equals-default
modernize-use-equals-delete
modernize-use-nullptr
modernize-use-override
modernize-use-transparent-functors
modernize-use-using
performance-faster-string-find
performance-for-range-copy
performance-implicit-cast-in-loop
performance-inefficient-string-concatenation
performance-type-promotion-in-math-fn
performance-unnecessary-copy-initialization
performance-unnecessary-value-paramnn
See http://releases.llvm.org/4.0.0/tools/clang/tools/extra/docs/clang-tidy/index.html for details.