-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLT DQM for 9.3.x - part 4 #19916
HLT DQM for 9.3.x - part 4 #19916
Conversation
…QM92X Conflicts: DQMOffline/Trigger/python/ExoticaMonitoring_Client_cff.py DQMOffline/Trigger/python/ExoticaMonitoring_cff.py
…nt with HLT configuration)
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
hi @fwyzard - except for METplusTrackMonitor.cc this is ready (ok, modulo the strange TProfiles and # of bins that are known issues that i guess will be sorted out by dqm once all the prs go in). so - if you want to remove that PR the rest can go - i'll comment on the one cc file when I get a bit more time. |
hi @davidlange6, Would you be amenable to merging this PR is I just disable the use of METplusTrackMonitor at the python level, and apply any fixes you request in a follow up PR before re-enabling it ? Otherwise, I can redo the work if you prefer not to have the code in the release at all. |
…placedJetEffFromHitPatternHLT in DQMOffline_SecondStep_cff.py
Actually, this cherry-picks the relevant commits rather than doing a full merge.
Pull request #19916 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
This is my "quick" proposal in practice:
.A |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Thanks ! |
hi @davidlange6 , I've created #19946 to enable the MET + track trigger DQM. |
Follow up to #19891 and #19912.
Merge the following HLT DQM pull requests (in this order):
and address the issues raised in the discussion of #19499, #19267.