Modify CaloLayer1 emulator to properly handle saturation in all cases #20000

nsmith- · 2017-08-01T15:30:06Z

Will make a backport too.
Firmware already at P5
more info: https://indico.cern.ch/event/655486/contributions/2672892/attachments/1498500/2332845/nsmith_layer1Saturation.pdf

cmsbuild · 2017-08-01T15:30:24Z

A new Pull Request was created by @nsmith- (Nicholas Smith) for master.

It involves the following packages:

L1Trigger/L1TCaloLayer1

@cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

nsmith- · 2017-08-01T15:30:32Z

Oh sweet 20000 do I get a prize?

rekovic · 2017-08-01T15:32:38Z

please test

cmsbuild · 2017-08-01T15:32:52Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21974/console Started: 2017/08/01 18:17

rekovic · 2017-08-01T15:32:53Z

@nsmith-
hopefully yes.

cmsbuild · 2017-08-01T17:57:06Z

+1
Tested at: bbce430
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20000/21974/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ff15bd6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20000/21974/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20000/21974/git-merge-result

cmsbuild · 2017-08-01T17:57:10Z

Comparison job queued.

cmsbuild · 2017-08-01T23:36:08Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20000/21974/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 25
DQMHistoTests: Total histograms compared: 2651091
DQMHistoTests: Total failures: 31628
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2619282
DQMHistoTests: Total skipped: 181
DQMHistoTests: Total Missing objects: 0
Checked 102 log files, 14 edm output root files, 25 DQM output files

nsmith- · 2017-08-09T11:40:17Z

@rekovic can you sign this? (also #20001)

rekovic · 2017-08-14T11:50:34Z

+1

cmsbuild · 2017-08-14T11:50:48Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

davidlange6 · 2017-08-16T01:58:53Z

L1Trigger/L1TCaloLayer1/python/simCaloStage2Layer1Digis_cfi.py

@@ -18,5 +18,5 @@
    unpackEcalMask = cms.bool(False),
    unpackHcalMask = cms.bool(False),
    # See UCTLayer1.hh for firmware version
-    firmwareVersion = cms.int32(1),
+    firmwareVersion = cms.int32(3),


hi @nsmith @rekovic - does this change work for all stage 2 data?

Yes and no, the change will not break the ability to re-emulate using old data, but the bit-level agreement will be broken with old (bugged firmware) data.
So far, there has in general been no requirement that L1T emulation can reproduce historic data at bit-level automatically. (the latest firmware and latest emulator should agree of course)

hi @nsmith-interesting- remind me how this code gets used in production workflows?

it is part of the stage2 L1 trigger emulation, not sure what you are asking specifically

davidlange6 · 2017-08-16T01:59:57Z

L1Trigger/L1TCaloLayer1/src/L1TCaloLayer1FetchLUTs.cc

-          if(value > 0xFF) {
-            value = 0xFF;
+          if ( fwVersion > 2 ) {
+            uint32_t absCaloEta = abs(caloEta);


please use std::abs

cmsbuild · 2017-09-27T15:34:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20000/998

cmsbuild · 2017-09-27T15:34:47Z

Pull request #20000 was updated. @cmsbuild, @rekovic, @mulhearn can you please check and sign again.

nsmith- · 2017-09-27T15:35:52Z

Well https://github.com/cms-sw/cmssw/releases/CMSSW_9_4_0_pre1 was, but I guess the original base of this PR wasn't 930. Sorry for the noise
edit: guess not, where do these get cut from then? some random point inbetween 930pre?

rekovic · 2017-10-03T13:38:57Z

please test

cmsbuild · 2017-10-03T13:39:13Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23401/console Started: 2017/10/03 16:00

cmsbuild · 2017-10-03T16:43:15Z

+1
Tested at: f0f2a7c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20000/23401/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
66f2f62
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20000/23401/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20000/23401/git-merge-result

cmsbuild · 2017-10-03T16:43:18Z

Comparison job queued.

rekovic · 2017-10-03T17:08:52Z

+1

cmsbuild · 2017-10-03T17:09:16Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2017-10-03T17:23:28Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20000/23401/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2761357
DQMHistoTests: Total failures: 249
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2760921
DQMHistoTests: Total skipped: 187
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 10 edm output root files, 26 DQM output files

davidlange6 · 2017-10-05T08:21:24Z

+1

davidlange6 · 2017-10-05T08:22:13Z

as for "Why the heck is 930 not an ancestor of 940" - its because the development for 940 starts before 930 is cut (the break point is when the features of 930 are finalized)

cmsbuild added this to the CMSSW_9_3_X milestone Aug 1, 2017

cmsbuild added comparison-pending l1-pending orp-pending pending-signatures tests-pending labels Aug 1, 2017

nsmith- mentioned this pull request Aug 1, 2017

Modify CaloLayer1 emulator to properly handle saturation in all cases #20001

Closed

cmsbuild added tests-started and removed tests-pending labels Aug 1, 2017

cmsbuild added tests-approved and removed tests-started labels Aug 1, 2017

cmsbuild added comparison-available and removed comparison-pending labels Aug 1, 2017

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Aug 14, 2017

davidlange6 reviewed Aug 16, 2017

View reviewed changes

cmsbuild removed upgrade-pending visualization-pending labels Sep 27, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 27, 2017

cmsbuild added tests-started and removed tests-pending labels Oct 3, 2017

cmsbuild added tests-approved and removed tests-started labels Oct 3, 2017

cmsbuild removed the l1-pending label Oct 3, 2017

cmsbuild added fully-signed l1-approved and removed pending-signatures labels Oct 3, 2017

cmsbuild added comparison-available and removed comparison-pending labels Oct 3, 2017

cmsbuild added orp-approved and removed orp-pending labels Oct 5, 2017

cmsbuild merged commit 5d51435 into cms-sw:master Oct 5, 2017

nsmith- deleted the layer1ProperSaturation_93x branch April 10, 2018 13:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modify CaloLayer1 emulator to properly handle saturation in all cases #20000

Modify CaloLayer1 emulator to properly handle saturation in all cases #20000

nsmith- commented Aug 1, 2017

cmsbuild commented Aug 1, 2017

nsmith- commented Aug 1, 2017

rekovic commented Aug 1, 2017

cmsbuild commented Aug 1, 2017 •

edited

rekovic commented Aug 1, 2017

cmsbuild commented Aug 1, 2017

cmsbuild commented Aug 1, 2017

cmsbuild commented Aug 1, 2017

nsmith- commented Aug 9, 2017

rekovic commented Aug 14, 2017

cmsbuild commented Aug 14, 2017

davidlange6 Aug 16, 2017

nsmith- Aug 16, 2017

davidlange6 Aug 22, 2017

nsmith- Aug 23, 2017

davidlange6 Aug 16, 2017

cmsbuild commented Sep 27, 2017

cmsbuild commented Sep 27, 2017

nsmith- commented Sep 27, 2017 •

edited

rekovic commented Oct 3, 2017

cmsbuild commented Oct 3, 2017 •

edited

cmsbuild commented Oct 3, 2017

cmsbuild commented Oct 3, 2017

rekovic commented Oct 3, 2017

cmsbuild commented Oct 3, 2017

cmsbuild commented Oct 3, 2017

davidlange6 commented Oct 5, 2017

davidlange6 commented Oct 5, 2017

Modify CaloLayer1 emulator to properly handle saturation in all cases #20000

Modify CaloLayer1 emulator to properly handle saturation in all cases #20000

Conversation

nsmith- commented Aug 1, 2017

cmsbuild commented Aug 1, 2017

nsmith- commented Aug 1, 2017

rekovic commented Aug 1, 2017

cmsbuild commented Aug 1, 2017 • edited

rekovic commented Aug 1, 2017

cmsbuild commented Aug 1, 2017

cmsbuild commented Aug 1, 2017

cmsbuild commented Aug 1, 2017

nsmith- commented Aug 9, 2017

rekovic commented Aug 14, 2017

cmsbuild commented Aug 14, 2017

davidlange6 Aug 16, 2017

Choose a reason for hiding this comment

nsmith- Aug 16, 2017

Choose a reason for hiding this comment

davidlange6 Aug 22, 2017

Choose a reason for hiding this comment

nsmith- Aug 23, 2017

Choose a reason for hiding this comment

davidlange6 Aug 16, 2017

Choose a reason for hiding this comment

cmsbuild commented Sep 27, 2017

cmsbuild commented Sep 27, 2017

nsmith- commented Sep 27, 2017 • edited

rekovic commented Oct 3, 2017

cmsbuild commented Oct 3, 2017 • edited

cmsbuild commented Oct 3, 2017

cmsbuild commented Oct 3, 2017

rekovic commented Oct 3, 2017

cmsbuild commented Oct 3, 2017

cmsbuild commented Oct 3, 2017

davidlange6 commented Oct 5, 2017

davidlange6 commented Oct 5, 2017

cmsbuild commented Aug 1, 2017 •

edited

nsmith- commented Sep 27, 2017 •

edited

cmsbuild commented Oct 3, 2017 •

edited