Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify CaloLayer1 emulator to properly handle saturation in all cases #20001

Closed

Conversation

nsmith-
Copy link
Contributor

@nsmith- nsmith- commented Aug 1, 2017

Backport of #20000
Necessary (at least) for online DQM data-emulator comparisons

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

A new Pull Request was created by @nsmith- (Nicholas Smith) for CMSSW_9_2_X.

It involves the following packages:

L1Trigger/L1TCaloLayer1

@cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor

rekovic commented Aug 1, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21975/console Started: 2017/08/01 18:21

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20001/21975/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1791781
  • DQMHistoTests: Total failures: 29449
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1762166
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Aug 14, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@rekovic
Copy link
Contributor

rekovic commented Oct 5, 2017

I need to put in Stage2L1Trigger_2017 modifier in 92x.

@davidlange6
Copy link
Contributor

CMSSW_9_2_X developement work is completed. Closing remaining PRs

@nsmith- nsmith- deleted the layer1ProperSaturation_92x branch April 10, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants