CTPPS Pixel unpacker patch #20120
CTPPS Pixel unpacker patch #20120
Conversation
|
A new Pull Request was created by @fabferro (Fabrizio Ferro) for master. It involves the following packages: EventFilter/CTPPSRawToDigi @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -148,6 +148,12 @@ void CTPPSPixelDataFormatter::interpretRawData( bool& errorsInEvent, int fedId, | |||
| int dcol = (ww >> m_DCOL_shift) & m_DCOL_mask; | |||
| int pxid = (ww >> m_PXID_shift) & m_PXID_mask; | |||
|
|
|||
| if(dcol<0||dcol>=26||pxid<2||pxid>161){ | |||
There was a problem hiding this comment.
are there constants already defined for these ranges 0-25 and 2-160?
If so, please use them instead of the magic numbers.
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pr-code-checks/PR-20120/28 |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 for #20120 5334e0e
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
adding small patch in the unpacker to prevent corrupted row/col from making the jobs crash