Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating the E/gamma HLT TnP DQM to have muon tags #20167

Merged
merged 3 commits into from Sep 6, 2017

Conversation

Sam-Harper
Copy link
Contributor

Dear All,

This update of the E/gamma HLT TnP DQM package now allows triggers to be monitored by muon tags, adding further cross trigger monitoring. It is also enabled for a few select electron triggers to be able to monitor e/gamma problems that may impact the tag & probe in a correlated way (online beamspot issues immediately jump to mind there)

As well as adding DQM plots where the tag is a muon, this update also fixes the newly introduced for V3 HLT_Ele32_WPTight_Gsf filters which were slightly miss named.

The new filters have been tested on ttbar lepton relval sample and the results are below, showing the filters run and are filled. The full listing is at
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/

HLT_Ele32_WPTight_Gsf:
ele tag:
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/eleWPTightTag_HLT_Ele32_WPTight_Gsf_hltEle32WPTightGsfTrackIsoFilter.gif
muon tag:
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/muonIsoMuTagEleProbe_HLT_Ele32_WPTight_Gsf_hltEle32WPTightGsfTrackIsoFilter.gif

HLT_Ele32_WPTight_Gsf_L1DoubleEG:
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/muonIsoMuTagEleProbe_HLT_Ele32_WPTight_Gsf_L1DoubleEG_hltEle32L1DoubleEGWPTightGsfTrackIsoFilter.gif

HLT_DoubleEle33_CaloIdL_MW:
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/muonIsoMuTagEleProbe_HLT_DoubleEle33_CaloIdL_MW_hltEle33CaloIdLMWPMS2Filter.gif

HLT_Mu12_DoublePhoton20:
with photon probe:
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/muonIsoMuTagPhoProbe_HLT_Mu12_DoublePhoton20_hltMu12DiEG20HEUnseededFilter.gif
with electron probe
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/muonIsoMuTagEleProbe_HLT_Mu12_DoublePhoton20_hltMu12DiEG20HEUnseededFilter.gif

HLT_Mu27_Ele37_CaloIdL_MW:
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/muonIsoMuTagEleProbe_HLT_Mu27_Ele37_CaloIdL_MW_hltEle37CaloIdLMWPMS2UnseededFilter.gif

HLT_Mu37_Ele27_CaloIdL_MW:
https://sharper.web.cern.ch/sharper/cms/trig/2017/Aug14th_muDQM/muonIsoMuTagEleProbe_HLT_Mu37_Ele27_CaloIdL_MW_hltEle27CaloIdLMWPMS2UnseededFilter.gif

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Sam-Harper for master.

It involves the following packages:

DQMOffline/Trigger

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22296/console Started: 2017/08/15 02:44

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20167/22296/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2712759
  • DQMHistoTests: Total failures: 274
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2712296
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@mtosi
Copy link
Contributor

mtosi commented Aug 15, 2017

thanks !
may I ask you the amount of bins added by this PR ?
do you think we can decrease (in the upcoming weeks) the binning, above all in the 2D plots ?
thanks !

ah, do you have the backport for 92x ?

@Sam-Harper
Copy link
Contributor Author

Hi @mtosi

I'll do the backport once its generally accepted that this is done.

As for binning, well I could dump all HEM17 and HEP17 plots for this package. That would save 2/3rds of the histograms. They so far have not been that useful. The 2D plots are reasonably sensibility binned

@mtosi
Copy link
Contributor

mtosi commented Aug 15, 2017

in the root file I even find plots for
HLT_Ele27_Ele37_CaloIdL_MW ;)

@mtosi
Copy link
Contributor

mtosi commented Aug 15, 2017

tracked by #19142

@mtosi mtosi mentioned this pull request Aug 15, 2017
@Sam-Harper
Copy link
Contributor Author

so I have a plan to re-visit how I do HEP17 and HEM17. Should cut the number of bins by ~1/3. Will submit soon

@mtosi
Copy link
Contributor

mtosi commented Aug 15, 2017 via email

@cmsbuild
Copy link
Contributor

Pull request #20167 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

@mtosi
Copy link
Contributor

mtosi commented Aug 15, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22305/console Started: 2017/08/15 15:19

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20167/120

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20167/22305/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2689933
  • DQMHistoTests: Total failures: 281
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2689463
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@Sam-Harper
Copy link
Contributor Author

@kmaeshima @vanbesien, @vazzolini, @dmitrijus

just a ping on the status of approval of this. This PR adds more useful DQM plots for EGM while reducing the total bin count by ~50% so is a clear improvement.

@Sam-Harper
Copy link
Contributor Author

@kmaeshima @vanbesien, @vazzolini, @dmitrijus

another ping on the status of approval of this.

This PR adds more useful DQM plots for EGM while reducing the total bin count by ~50% so is a clear improvement

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

mtosi added a commit to mtosi/cmssw that referenced this pull request Sep 4, 2017
mtosi added a commit to mtosi/cmssw that referenced this pull request Sep 4, 2017
@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants