backport HLT DQM for menu v3.0 to CMSSW 9.2.x + HLTDQM : fix memory issue (part1) + add offlineHLTSourceOnAODextra sequence #20620
Conversation
|
@cmsbuild , please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @mtosi (mia tosi) for CMSSW_9_2_X. It involves the following packages: DQMOffline/Configuration @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
cmsbuild
added
comparison-available
comparison-pending
tests-pending
and removed
comparison-pending
comparison-available
tests-approved
labels
|
Pull request #20620 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again. |
|
@cmsbuild, please test
…On Fri, Sep 22, 2017 at 2:01 PM, cmsbuild ***@***.***> wrote:
Pull request #20620 <#20620> was
updated. @kmaeshima <https://github.com/kmaeshima>, @cmsbuild
<https://github.com/cmsbuild>, @vanbesien <https://github.com/vanbesien>,
@vazzolini <https://github.com/vazzolini>, @dmitrijus
<https://github.com/dmitrijus> can you please check and sign again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20620 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt58_YZj2ehSEs9lCyAOUiha7KlASgZks5sk6F8gaJpZM4Pf8le>
.
|
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
for completeness, the memory usage w/ all HLT plots enable is roughly 60MB ..... is it too much ? ==> the mentioned work on the DQM framework is really important, I guess |
cmsbuild
added
comparison-pending
dqm-pending
tests-pending
and removed
comparison-available
dqm-approved
tests-approved
labels
|
Pull request #20620 was updated. @prebello, @vazzolini, @dmitrijus, @kmaeshima, @kpedro88, @fabozzi, @cmsbuild, @franzoni, @GurpreetSinghChahal, @vanbesien, @davidlange6 can you please check and sign again. |
|
+1 |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
some fixes to be discussed for 94x once I write my suggestions up - but ok for 92x. |
|
merge |
many PRs for the HLT DQM did not enter 92x, yet
because the corresponding ones in 93x showed a big issue in memory,
as reported in [1] and discussed during (and after) the DQM meeting
they are --mainly--
the memory issue seems --at least partially-- addressed by PR #20439
here there is its backport in 92x, which should make the above PRs fine in 92x as well
this is the 1st --low level-- round, in which
(like the 2D in the HEM and HEP slices, which are simply a zoom of the full eta-phi map)
the best would be to move to variable binning
in this occasion, I also clean / re-organize the directories structure
==> the comparison plot by plot will fail
[1]
in https://indico.cern.ch/event/658725/contributions/2685778/attachments/1505407/2345690/dqm_memory.pdf
finally (?), as discussed at the recent XC
it would be probably safer to have a dedicated
cms.Sequencefor testing new DQM code for HLTwhich is meant to be used in the HLT validation workflow, but not necessarily at Tier0
new DQM code should be integrated in the offlineHLTSourceOnAODextra sequence
and then it could be ported in the standard offlineHLTSourceOnAOD one (which is run at Tier0)