[93X] Offline DQM extensions for L1T EGamma (calo layer 2) and fixes

[kreczko]

This PR implements the features requested in Jira ticket CMSLITDPG-171:

• changes to the electron thresholds
• additional histograms for all electron probes
• additional histograms for a subset of electron probes

In addition, this PR includes

• fixes for the last bins for the efficiency histograms in L1T EGamma, Jets, Sums and Taus (last bin was ommited)
• L1TEfficiency harvesting can now handle 2D histograms (needed for ticket)
• changed edm::LogError to edm::LogWarning for the message regarding a missing matched L1T jet

[cmsbuild]

A new Pull Request was created by @kreczko (Luke Kreczko) for master.

It involves the following packages:

DQMOffline/L1Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please review it and eventually sign? Thanks.
@thomreis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20227/247

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20227/247/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20227/247/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

[smuzaffar]

code-checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20227/290

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20227/290/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20227/290/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

Pull request #20227 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20227/323

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22540/console Started: 2017/08/29 08:32

[cmsbuild]

+1
Tested at: 0a92db3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20227/22540/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f91659f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20227/22540/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20227/22540/git-merge-result

[cmsbuild]

Comparison job queued.

[rekovic]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20227/22540/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2653286
• DQMHistoTests: Total failures: 212
• DQMHistoTests: Total nulls: 593
• DQMHistoTests: Total successes: 2652292
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1