Topic photonvbf trigger #20277
Topic photonvbf trigger #20277
Conversation
|
@yiiyama, CMSSW_9_3_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
|
The code-checks are being triggered in jenkins. |
|
A new Pull Request was created by @yiiyama (Yutaro Iiyama) for master. It involves the following packages: DQMOffline/Trigger @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20277/333 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20277/333/git-diff.patch In future, you can run |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
@yiiyama could you please point to the main plots produced by your PR ? |
|
@mtosi I ran tests from runTheMatrix, and none really produced significant results. One test 136.788 runs on SinglePhoton dataset and there I could at least see that the Mjj cut on the trigger is working: http://yiiyama.web.cern.ch/yiiyama/photonvbf_hlt/mjj_denominator.pdf The plots show the Mjj "distributions" made by the new Photon75_R9Id90_HE10_IsoM_EBOnly_PFJetsMJJ300DEta3 module. The denominator are the events firing the Photon75 control trigger and have a 75 GeV photon in the barrel. The numerator are the subset of those where the new trigger (with Mjj cut) fired. We see that the one event in the denominator having 100 GeV of Mjj is rejected by the trigger - at least it's not firing on such events. The PR adds 35028 TProfile bins and 3278 TH1F bins, including underflow and overflow. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
@yiiyama thanks for the prompt feedback |
|
I can only make a trivial efficiency plot from histograms like these.. :( Do you want me to run RECO-DQM on some big RAW dataset (will take time)? |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
DQM for the proposed Photon + VBF triggers [1].
Adding ability to cut on photon variables in ObjMonitor.cc and using that feature in two new modules defined in PhotonMonitor_cff.py.
[1] https://indico.cern.ch/event/658287/contributions/2693061/attachments/1508864/2352214/photonVBF.pdf