New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic photonvbf trigger #20277
Merged
Merged
Topic photonvbf trigger #20277
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6511f2d
Adding monitoring modules for VBF and MET legs of photon+MET+VBF path
1912f48
dropping EBOnly path but adding a photon selection to ObjMonitor
bcd36df
config for /users/yiiyama/VBFPhoton926H1/V11
6c2c85b
changed binning
yiiyama 13d199d
adding JetMET efficiency plots for Photon+VBF paths
yiiyama b6c5171
correcting unnecessary c_str
yiiyama 4521566
changing n*_ variables type to unsigned
yiiyama File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @yiiyama - please make this an unsigned int (the others should be too, but they are already there...)- this will save several int() below..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @davidlange6 yes I wanted to make as little change as possible to the original code, but personally I actually feel sick when variables that are semantically unsigned are declared / cast as int..
Taking the opportunity, I changed all n*_ member variables to unsigned. But there would be too much change if I updated the parameter type (to getParameter), so I left that part as int.