-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale down Castor photoelectron gain at digi step to avoid saturation in simulation of PbPb #2035
Scale down Castor photoelectron gain at digi step to avoid saturation in simulation of PbPb #2035
Conversation
…turation in PbPb simulation; this assumes also a corresponding check of conditions
A new Pull Request was created by @iik1997 for CMSSW_5_3_X. Scale down Castor photoelectron gain at digi step to avoid saturation in simulation of PbPb It involves the following packages: SimCalorimetry/CastorSim @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it? |
@iik1997, I have signed this pull request but the question is left: you changed default parameter which was working for pPb to the value needed for PbPb but there is no mechanism to select one or another depending of type of run. |
@civanch, let me please point out the following |
@iik1997, in other places we use following approach: keep list of parameters 5_3_X unchanged, for specific runs use custom fragments allowing to have different parameters value for GEN-SIM production. In this case fragments may have names "castor_PbPb_cfi.py", "castor_pPb_cfi.py"... |
@civanch, according to Castor software coordinator, Hans Van Haevermaet, such a customization already exists to extend the eta range in the simulation to include Castor (SimWithCastor). We will then need to include multiple ones at the same time. Would you advise to prepare additional customization fragments? |
Yes On Jan 28, 2014, at 1:46 PM, iik1997 notifications@github.com
|
Using inputs to cmsDriver similar to: Hydjet_Quenched_MinBias_2760GeV_cfi --conditions auto:starthi_HIon --scenario HeavyIons -n 1 --customise Configuration/StandardSequences/SimWithCastorPbPb_cff.customise --eventcontent RAWSIM --relval 500,5 -s GEN,SIM --datatier GEN-SIM (step1) and step2 --inputCommands keep ,drop *simEcalPreshowerDigis_* --conditions auto:starthi_HIon -s DIGI,L1,DIGI2RAW,HLT:HIon,RAW2DIGI,L1Reco --scenario HeavyIons --datatier GEN-SIM-DIGI-RAW-HLTDEBUG -n 1 --customise Configuration/StandardSequences/SimWithCastorPbPb_cff.customise --eventcontent FEVTDEBUGHLT (step2) I got 3 custom fragments, SimWithCastorPbPb_cff.py, SimWithCastorPPb_cff.py and SimWithCastorPP_cff.py, running (all 3 are modifications of standardConfiguration/StandardSequences/python/SimWithCastor_cff.py). I checked also that the parameter of interest, photoelectronsToAnalog, was properly set in all 3 cases. Please note that I used (the same) customization fragment both at step 1 and step 2 (once to set the eta-range and another time to set the parameter in question). How would you recommend to proceed? Should I somehow abandon this pull request and initiate another one for the 3 fragments? Thanks |
May be easier is to close this pull request and open a new one. In comment to the new PR make a reference this PR. Alternatively it is possible to update this one if you keep your branch. |
… value appropriate for pPb simulation as it initially was for 1st 53X releases. -- Added three custom fragments with the Castor photoelectron gain values appropriate for all possible cases that is for pp, pPb, PbPb simulation. -- Tested the fragments both at GEN-SIM (the same way as it was working for original SimWithCastor_cff) and DIGI steps (where photoelectronsToAnalog is in fact used). -- Each fragment requires a matching set of conditions (CastorGains). -- Hopefully now the solution should be universal within 53X.
@civanch, @davidlange6 |
Pull request #2035 was updated. @civanch, @nclopezo, @vlimant, @mdhildreth, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please check and sign again. |
+1 |
+1 |
+tested |
…-sync-with-53X-rereco-mc-conditions Scale down Castor photoelectron gain at digi step to avoid saturation in simulation of PbPb
Castor calorimeter pmt gain, photoelectronsToAnalog, set to 4.24 divided by 20 to work around saturation of digital signals in PbPb simulation; this assumes also a corresponding check of conditions (previous setup was 4.24 / 5 and was valid for pPb)