Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated relval gridpacks for gcc630 #20515

Merged
merged 1 commit into from Sep 22, 2017

Conversation

pmillet
Copy link
Contributor

@pmillet pmillet commented Sep 14, 2017

as mentioned in cms-sw/cmsdist#3367

@cmsbuild cmsbuild changed the base branch from CMSSW_9_4_X to master September 14, 2017 13:27
@cmsbuild
Copy link
Contributor

@pmillet, CMSSW_9_4_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20515/697

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pmillet for master.

It involves the following packages:

Configuration/Generator

@cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test workflow 534.0 with #20401

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 14, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22976/console Started: 2017/09/14 16:55

@perrozzi
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20515/22976/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2646869
  • DQMHistoTests: Total failures: 203
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2646477
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

hi @pmillet @smuzaffar - how can we make this work for any scram_arch (of course the gridlpacks would have to be there, but thats a second topic)

@pmillet
Copy link
Contributor Author

pmillet commented Sep 15, 2017

We could scram_arch and sherpa version from environment variables in a similar way as the openloops version. Not sure about the checksum though. One could add a dict storing the checksums for each scram_arch/sherpa version. We would still need to update the files once there is a new scram_arch or some major sherpa update.

@davidlange6
Copy link
Contributor

hi @pmillet - sorry for the slow answer - that sort of lookup table would go a long way to future proof this code - its better to have a clean failure in cases where an architecture is not supported..

@pmillet
Copy link
Contributor Author

pmillet commented Sep 19, 2017

@davidlange6 -
Another way would be to disable the checksum check (ensures that copying of the gridpack was successful) for the release validation samples and get sherpa version / architecture from environment variables. This would remove the need to update these python fragments for each new architecture and sherpa version but does not need a dict for the different checksums. It will still crash when the files are not there.

@davidlange6
Copy link
Contributor

Right - a small checksum dictionary is also supportable I think. Anyway, please have a look at what you think is best.

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants