New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated relval gridpacks for gcc630 #20515
Conversation
@pmillet, CMSSW_9_4_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @pmillet for master. It involves the following packages: Configuration/Generator @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 534.0 with #20401 |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
hi @pmillet @smuzaffar - how can we make this work for any scram_arch (of course the gridlpacks would have to be there, but thats a second topic) |
We could scram_arch and sherpa version from environment variables in a similar way as the openloops version. Not sure about the checksum though. One could add a dict storing the checksums for each scram_arch/sherpa version. We would still need to update the files once there is a new scram_arch or some major sherpa update. |
hi @pmillet - sorry for the slow answer - that sort of lookup table would go a long way to future proof this code - its better to have a clean failure in cases where an architecture is not supported.. |
@davidlange6 - |
Right - a small checksum dictionary is also supportable I think. Anyway, please have a look at what you think is best. |
+1 |
as mentioned in cms-sw/cmsdist#3367