Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes for RHStopTracer (93X) #20446

Merged
merged 3 commits into from Sep 15, 2017

Conversation

jalimena
Copy link
Contributor

@jalimena jalimena commented Sep 9, 2017

backport of #20421

This pull request is to fix two bugs that were introduced into the RHStopTracer module:

  • First, the particle names need to be matched with a regular expression
  • Secondly, we want to record a "stopped particle" if the particle name is matched OR if the energy of the particle is very high (not AND)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2017

A new Pull Request was created by @jalimena (Juliette Alimena) for CMSSW_9_3_X.

It involves the following packages:

SimG4Core/CustomPhysics

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Sep 10, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22838/console Started: 2017/09/10 17:37

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20446/22838/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2641982
  • DQMHistoTests: Total failures: 213
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2641580
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #20446 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

@civanch
Copy link
Contributor

civanch commented Sep 12, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22908/console Started: 2017/09/12 19:41

@cmsbuild
Copy link
Contributor

Pull request #20446 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

@civanch
Copy link
Contributor

civanch commented Sep 15, 2017

please test

@civanch
Copy link
Contributor

civanch commented Sep 15, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 15, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23002/console Started: 2017/09/15 11:57

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20446/23002/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2641982
  • DQMHistoTests: Total failures: 202
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2641591
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9c60c7f into cms-sw:CMSSW_9_3_X Sep 15, 2017
@jalimena jalimena deleted the RHStopTracerFix93X branch November 11, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants