Fix to prevent possible crashes if the prescale table changes during job

[apana]

Fix to prevent possible crashes in the L1TGlobalUtil code in CMSSW jobs where the prescale table is updated during the job. In the previous version this could sometimes cause an out-of-range exception.

[cmsbuild]

A new Pull Request was created by @apana (Leonard Apanasvich) for CMSSW_9_2_X.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix to prevent possible crashes if the prescale table changes during job #20503

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22929/console Started: 2017/09/13 08:02

[cmsbuild]

+1
Tested at: d125ffa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20488/22929/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
43abbee
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20488/22929/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20488/22929/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20488/22929/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1904557
• DQMHistoTests: Total failures: 14526
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1889857
• DQMHistoTests: Total skipped: 174
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

hi -
what is the master branch PR for this back port?

[rekovic]

@davidlange6
I am not sure that there is one. I will make one now.

[Martin-Grunewald]

It is #20503

[rekovic]

Yes. Just saw it.

[rekovic]

And L1 signed it.

Thanks @Martin-Grunewald.

[rekovic]

backport of #20503

[davidlange6]

+1