Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeavyFlavor Validation update #20520

Merged
merged 7 commits into from Sep 26, 2017

Commits on Aug 17, 2017

  1. Copy the full SHA
    1e6729c View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2017

  1. Copy the full SHA
    44a3535 View commit details
    Browse the repository at this point in the history
  2. Make filter level assignment based on module names a bit more stable.

    Internally used filter level assignment relied on the name of the modules,
    which can be ambiguous. Added an additional check on the type of the module
    to be a bit more stable and to prevent from multiple modules on the same level.
    
    The newly introduced function yields the same levels as the previous definition
    in dqmBeginRun, without having multiple modules on the same level.
    
    Removed some trailing whitespace as well.
    tmadlener committed Aug 20, 2017
    Copy the full SHA
    533e844 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2017

  1. Apply code-checks patch

    tmadlener committed Sep 17, 2017
    Copy the full SHA
    35a98f3 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2017

  1. Copy the full SHA
    bd0826f View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2017

  1. Fix clang errors by replacing constexpr char[] by const std::string.

    clang complained about arrays of chars not being initialized by a
    constant expression. (gcc compiles without warning on this)
    
    Subsequently the call to 'isAnyOf' does not succeed due to:
    no known conversion from 'const initializer_list<const char *>' to 'const initializer_list<const const char *>' for 2nd argument
    
    Removing the second const from const char* const would allow clang to compile
    but breaks the gcc build due to the same reasoning (but with reversed arguments in this case).
    
    Since this is called only in setup I have simply replaced all constexpr char[] by std::string.
    tmadlener committed Sep 19, 2017
    Copy the full SHA
    09217a6 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2017

  1. Implement Davids comments from code review.

    - Avoid usage of stringstream where concatenating strings is possible.
    - Make filter level assignment stable enough to allow for early returns.
    tmadlener committed Sep 25, 2017
    Copy the full SHA
    c098acf View commit details
    Browse the repository at this point in the history