correctly update boundary box preventing overwriting in case a hit ha…

[clelange]

…s x value = 0

This fixes a bug in the HGCal layer clustering: the "box" that was built from the hits that pass the energy thresholds was erroneously reset in case a hit had an x-value of 0. This limited the area used for the clustering, losing whole layer clusters for no reason. It's fixed now using a boolean for each layer. The consequence is that some multiclusters will have more energy than before (and a couple more layer clusters will be built).

This is the back-port of #20521 to CMSSW_9_3_X.

[cmsbuild]

A new Pull Request was created by @clelange (Clemens Lange) for CMSSW_9_3_X.

It involves the following packages:

RecoLocalCalo/HGCalRecAlgos

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@edjtscott, @vandreev11, @sethzenz, @felicepantaleo, @kpedro88, @argiro, @cseez, @pfs, @lgray this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

• Backported from correctly update boundary box preventing overwriting in case a hit ha… #20521

[kpedro88]

backport of #20521

[kpedro88]

@clelange is this needed for the TDR release?

[cmsbuild]

Pull request #20522 was updated. @perrotta, @cmsbuild, @kpedro88, @slava77 can you please check and sign again.

[clelange]

@kpedro88 It would be good if this was part of the TDR release, but since the effect does not seem to be too big, it is not a show stopper in case it comes too late.

[kpedro88]

it's most likely too late already

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22987/console Started: 2017/09/14 22:52

[cmsbuild]

+1
Tested at: da1b95c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20522/22987/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d39a26d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20522/22987/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20522/22987/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20522/22987/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2641982
• DQMHistoTests: Total failures: 209
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2641584
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[kpedro88]

+1

[perrotta]

+1

• Same as correctly update boundary box preventing overwriting in case a hit ha… #20521 in the master
• Bug fix: small effect on final quantities but it is deserved

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1