Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly update boundary box preventing overwriting in case a hit ha… #20522

Merged
merged 2 commits into from Sep 19, 2017
Merged

correctly update boundary box preventing overwriting in case a hit ha… #20522

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30025e3
correctly update boundary box preventing overwriting in case a hit ha…
clelange Sep 14, 2017
da1b95c
apply code checks
clelange Sep 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions RecoLocalCalo/HGCalRecAlgos/src/HGCalImagingAlgo.cc
View file
Open in desktop
Expand Up @@ -18,6 +18,7 @@ void HGCalImagingAlgo::populate(const HGCRecHitCollection& hits){
computeThreshold();
}

std::vector<bool> firstHit(2*(maxlayer+1), true);
for (unsigned int i=0;i<hits.size();++i) {

const HGCRecHit& hgrh = hits[i];
Expand Down Expand Up @@ -48,9 +49,10 @@ void HGCalImagingAlgo::populate(const HGCRecHitCollection& hits){
points[layer].emplace_back(Hexel(hgrh,detid,isHalf,sigmaNoise,thickness,&rhtools_),position.x(),position.y());

// for each layer, store the minimum and maximum x and y coordinates for the KDTreeBox boundaries
if(minpos[layer][0] == 0.0f){
if(firstHit[layer]){
minpos[layer][0] = position.x(); minpos[layer][1] = position.y();
maxpos[layer][0] = position.x(); maxpos[layer][1] = position.y();
firstHit[layer] = false;
}else{
minpos[layer][0] = std::min((float)position.x(),minpos[layer][0]);
minpos[layer][1] = std::min((float)position.y(),minpos[layer][1]);
Expand Down Expand Up @@ -240,7 +242,7 @@ double HGCalImagingAlgo::calculateDistanceToHigher(std::vector<KDNode> &nd){
int nearestHigher = -1;


if(rs.size()>0)
if(!rs.empty())
maxdensity = nd[rs[0]].data.rho;
else
return maxdensity; // there are no hits
Expand Down