Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MiniAOD: PackedCandidate::setP4 preserve track kinematic #20574

Merged
merged 2 commits into from Sep 26, 2017
Merged

MiniAOD: PackedCandidate::setP4 preserve track kinematic #20574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
935d985
update the delta pt,eta,phi when calling setP4 and setPz so that trac…
arizzi Sep 19, 2017
79969de
adding unit tests and minor fix
arizzi Sep 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions DataFormats/PatCandidates/interface/PackedCandidate.h
View file
Open in desktop
Expand Up @@ -371,12 +371,18 @@ namespace pat {
/// set 4-momentum
virtual void setP4( const LorentzVector & p4 ) {
maybeUnpackBoth(); // changing px,py,pz changes also mapping between dxy,dz and x,y,z
dphi_+=polarP4().Phi()-p4.Phi();
deta_+=polarP4().Eta()-p4.Eta();
dtrkpt_+=polarP4().Pt()-p4.Pt();
*p4_ = PolarLorentzVector(p4.Pt(), p4.Eta(), p4.Phi(), p4.M());
packBoth();
}
/// set 4-momentum
virtual void setP4( const PolarLorentzVector & p4 ) {
maybeUnpackBoth(); // changing px,py,pz changes also mapping between dxy,dz and x,y,z
dphi_+=polarP4().Phi()-p4.Phi();
deta_+=polarP4().Eta()-p4.Eta();
dtrkpt_+=polarP4().Pt()-p4.Pt();
*p4_ = p4;
packBoth();
}
Expand All @@ -389,6 +395,9 @@ namespace pat {
virtual void setPz( double pz ) {
maybeUnpackBoth(); // changing px,py,pz changes also mapping between dxy,dz and x,y,z
*p4c_ = LorentzVector(p4c_.load()->Px(), p4c_.load()->Py(), pz, p4c_.load()->E());
dphi_+=polarP4().Phi()- p4c_.load()->Phi();
deta_+=polarP4().Eta()- p4c_.load()->Eta();
dtrkpt_+=polarP4().Pt()- p4c_.load()->Pt();
*p4_ = PolarLorentzVector(p4c_.load()->Pt(), p4c_.load()->Eta(), p4c_.load()->Phi(), p4c_.load()->M());
packBoth();
}
Expand Down
13 changes: 13 additions & 0 deletions DataFormats/PatCandidates/test/testPackedCandidate.cc
View file
Open in desktop
Expand Up @@ -107,6 +107,19 @@ testPackedCandidate::testPackUnpack() {
CPPUNIT_ASSERT(tolerance(pc.ptTrk(),trkPt,0.001));
CPPUNIT_ASSERT(tolerance(pc.etaAtVtx(),trkEta,0.001));
CPPUNIT_ASSERT(tolerance(pc.phiAtVtx(),trkPhi,0.001));
//Check again after a setP4
pc.setP4(plv*2);
CPPUNIT_ASSERT(tolerance(pc.ptTrk(),trkPt,0.001));
CPPUNIT_ASSERT(tolerance(pc.etaAtVtx(),trkEta,0.001));
CPPUNIT_ASSERT(tolerance(pc.phiAtVtx(),trkPhi,0.001));
pc.setP4(lv*3);
CPPUNIT_ASSERT(tolerance(pc.ptTrk(),trkPt,0.001));
CPPUNIT_ASSERT(tolerance(pc.etaAtVtx(),trkEta,0.001));
CPPUNIT_ASSERT(tolerance(pc.phiAtVtx(),trkPhi,0.001));
pc.setPz(pc.p4().Pz()+3.3);
CPPUNIT_ASSERT(tolerance(pc.ptTrk(),trkPt,0.005));
CPPUNIT_ASSERT(tolerance(pc.etaAtVtx(),trkEta,0.005));
CPPUNIT_ASSERT(tolerance(pc.phiAtVtx(),trkPhi,0.005));
}

void testPackedCandidate::testSimulateReadFromRoot() {
Expand Down