Small changes in HCAL TP LUTs

[akhukhun]

The PR includes the following changes:

• use average adc2fC over four CapId's instead of the first one to calculate linearization LUTs.
  This has a small effect on TPs.
• pass HF FG bit threshold through the input LUTs as it's done online
• small cleanup to remove extra LUT arrays.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20602/847

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20602/847/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20602/847/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly (this will soon be required for PRs to be considered)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20602/850

[cmsbuild]

A new Pull Request was created by @akhukhun for master.

It involves the following packages:

CalibCalorimetry/HcalTPGAlgos
CalibCalorimetry/HcalTPGEventSetup
SimCalorimetry/HcalTrigPrimAlgos
SimCalorimetry/HcalTrigPrimProducers

@ghellwig, @arunhep, @cerminar, @cmsbuild, @rekovic, @franzoni, @mulhearn, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[arunhep]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23125/console Started: 2017/09/20 19:57

[cmsbuild]

+1
Tested at: ba6b6d8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20602/23125/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
822d7aa
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20602/23125/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20602/23125/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20602/23125/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2649968
• DQMHistoTests: Total failures: 1141
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2648638
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[rekovic]

+1

[arunhep]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1