Standard muon selectors #20612
Standard muon selectors #20612
Conversation
…d in SUSY analyses
…rking points applying EA-based pileup correction
…d in SUSY analyses
…rking points applying EA-based pileup correction
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20612/869 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20612/869/git-diff.patch You can run |
|
On 9/21/17 4:19 AM, drkovalskyi wrote:
Standard Muon Selectors - critical addition for 94X from Muon POG
Passed default tests and no problems were found running matrix.
please edit the PR description and add a link to slides with more
detailed description
for improved self-documentation.
Thank you.
|
|
@drkovalskyi |
| @@ -183,6 +183,43 @@ namespace reco { | |||
| RPCHitAndTrackArbitration, GEMSegmentAndTrackArbitration, ME0SegmentAndTrackArbitration }; | |||
|
|
|||
| /// | |||
| /// ====================== STANDARD SELECTORS =========================== | |||
| /// | |||
| enum Selector { | |||
There was a problem hiding this comment.
IDSelector may be more descriptive
There was a problem hiding this comment.
It's not ID. It's any selector including isolation.
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
It looks like the conflicts could have been avoided by a cleaner removal of the timing changes made and then taken out a week ago (as suggested in #20612 (comment)) Even before the merge conflicts appeared the commit graph in this PR already had about 3 cycles with 2 merges points with the CMSSW upstream. |
|
merge |
Standard Muon Selectors - critical addition for 94X from Muon POG
Passed default tests and no problems were found running matrix.
Latest presentation on the subject in the general muon POG meeting:
https://indico.cern.ch/event/666069/contributions/2721346/attachments/1524991/2384210/muon_pog_standard_selectors_for_MC2017v2.pdf