ability to set origin to one of primary vertices (tested on 94X release)

[alja]

[cmsbuild]

The code-checks are being triggered in jenkins.

[alja]

@Dr15Jones
Thanks for reminding me about #19871. I have closed it
and created this one based on master branch and CMSSW_9_4_0_pre1 release.

[alja]

+1

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20633/925

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20633/925/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-20633/925/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly (this will soon be required for PRs to be considered)

[Dr15Jones]

@alja you have to apply the -code-checks patch and then push the change to your github branch before the pull request tests can begin.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20633/971

[cmsbuild]

A new Pull Request was created by @alja (Alja Mrak-Tadel) for master.

It involves the following packages:

Fireworks/Calo
Fireworks/Core
Fireworks/Geometry
Fireworks/Vertices

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23236/console Started: 2017/09/26 20:15

[alja]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: 5918bbc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20633/23236/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6d77b69
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20633/23236/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20633/23236/git-merge-result

[cmsbuild]

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

[davidlange6]

+1